Fix "Dashboard doesn't display results if user navigates to open dashboard from discover" - Option 1 #64998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move old code to legacy folder * Use search service directly from search source * Move get search params to fetch folder * Delete search strategy folder * Doc update * Minor cleanups * Moved es client to legacy folder * Clean up some unused code (isViable, old search function) * Updated tests * strings update * Fix jest test * re-arrange runSearch function * re-arrange runSearch function * fix jest tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/data/public/search/search_service.ts # src/plugins/data/public/search/search_source/search_source.test.ts # src/plugins/data/public/search/search_source/search_source.ts # x-pack/legacy/plugins/rollup/public/search/rollup_search_strategy.ts # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
…/fix-search-cancelation-race-condition
2 tasks
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
added
bug
This was referenced May 1, 2020
💚 Build SucceededTo update your PR or re-run it, just comment with: |
|
Closing in favor of: #64999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes: #64709
by backporting: #63320
and functional test from: #64964
Option 2 fix with less file changes
Explanation:
In
7.7branch bothcourier:enableBatch: true / falseare going through this code path:https://github.com/elastic/kibana/blob/7.7/src/plugins/data/public/search/fetch/fetch_soon.ts#L64In case of
courier:enableBatch: falsems = 0. The assumption was that no request grouping could happen, but if requests were fired in scope of one micro task, then we still were batching requests. (delay used setTimeout).This was causing problems in case of request cancelations. If 1 request in group was canceled, we were canceling other requests also.
For example. in this dashboard, https://github.com/elastic/kibana/files/4558779/minimal.reproduction.zip, bar chart canceled pie chart's requests.
This backport is making
courier:enableBatch: falsesearch to not get intofetchSoonat all.Checklist
Delete any items that are not applicable to this PR.
For maintainers