Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallows commonjs in new platform public #65218

Merged
merged 1 commit into from
May 5, 2020
Merged

Disallows commonjs in new platform public #65218

merged 1 commit into from
May 5, 2020

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented May 5, 2020 •
edited
Loading

Prerequisite to enabling tree shaking on the new platform

Blocks #62390

Disallows commonjs in new platform public
d87b298 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley mentioned this pull request May 5, 2020
Closed
2 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #45389 failed 98171614f1b462b67fff4d78869ae82da755bc24

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley marked this pull request as ready for review May 5, 2020 15:47
@tylersmalley tylersmalley requested a review from a team as a code owner May 5, 2020 15:47
@tylersmalley tylersmalley requested a review from a team May 5, 2020 15:47
@tylersmalley tylersmalley requested a review from a team as a code owner May 5, 2020 15:47
@tylersmalley tylersmalley requested a review from a team May 5, 2020 15:47
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team labels May 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

flash1293
flash1293 approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graph changes LGTM, code review only

chrisronline
chrisronline approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from stack monitoring

walterra
walterra approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML code changes LGTM

cjcenizal
cjcenizal approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console code LGTM, tested locally and autocomplete, selective disabling of autocomplete suggestions, and highlighting seems to work as expected.

@cjcenizal cjcenizal added Feature:Console Dev Tools Console Feature Feature:Dev Tools labels May 5, 2020
@tylersmalley
Copy link
Contributor Author

Thanks all!

@tylersmalley tylersmalley merged commit df18747 into elastic:master May 5, 2020
@tylersmalley tylersmalley mentioned this pull request May 5, 2020
Merged
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request May 5, 2020
Disallows commonjs in new platform public (elastic#65218)
a5805ce 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request May 6, 2020
@elasticmachine
Disallows commonjs in new platform public (#65218) (#65298)
cb313ac 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request May 6, 2020
Disallows commonjs in new platform public (elastic#65218)
50de786 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley mentioned this pull request May 6, 2020
Merged
tylersmalley pushed a commit that referenced this pull request May 6, 2020
@elasticmachine
Disallows commonjs in new platform public (#65218) (#65547)
0f97a39 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@walterra walterra walterra approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tylersmalley @kibanamachine @elasticmachine @chrisronline @walterra @cjcenizal @flash1293