[SIEM][Detection Engine] Fixes import bug with non existent signals index #65595

FrankHassanabad · 2020-05-06T23:17:26Z

Fixes it to where if there is an import without an index then the rule is not created

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…ill creates the rules and activates them

FrankHassanabad · 2020-05-06T23:18:44Z

x-pack/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts

-                  if (parsedRule instanceof Error) {
-                    // If the JSON object had a validation or parse error then we return
-                    // early with the error and an (unknown) for the ruleId
+              const importsWorkerPromise = new Promise<ImportRuleResponse>(async resolve => {


NOTE: formatting is all messed up because I removed the dead variable reject

FrankHassanabad · 2020-05-06T23:19:25Z

x-pack/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts

-                        message: parsedRule.message,
+                        ruleId,
+                        statusCode: 409,
+                        message: `To create a rule, the index must exist first. Index ${signalsIndex} does not exist`,
                      })
                    );
                    return null;


NOTE: Ignore what the diff says, this return null is what I added and only what I added.

FYI You can always add ?w=1 to diff URIs, or select "Hide whitespaces changes" from the cog dropdown on the diff view.

Ah of course! I used to do that before. Totally forgot about that feature. Thank you!

elasticmachine · 2020-05-06T23:20:34Z

Pinging @elastic/siem (Team:SIEM)

x-pack/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts

dhurley14

LGTM - I think moving the index check above the while loop would be a minor improvement but not necessary. Thanks for the 🚫🐛

kibanamachine · 2020-05-07T05:35:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 52ed6b0

History

💚 Build #46164 succeeded 1fef901

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ndex (elastic#65595) See: elastic#65565 * Fixes it to where if there is an import without an index then the rule is not created ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

* master: [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)

…ponents * alerting/lazy-load-actions: align and style loading indicator [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)

…ndex (#65595) (#65690) See: #65565 * Fixes it to where if there is an import without an index then the rule is not created ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

elasticmachine · 2021-09-23T14:34:56Z

Pinging @elastic/security-solution (Team: SecuritySolution)

Fixes bug with import where if the signals index does not exist it st…

1fef901

…ill creates the rules and activates them

FrankHassanabad requested review from a team as code owners May 6, 2020 23:17

FrankHassanabad commented May 6, 2020

View reviewed changes

FrankHassanabad self-assigned this May 6, 2020

FrankHassanabad added v8.0.0 v7.8.0 bug Fixes for quality problems that affect the customer experience release_note:fix Team:SIEM labels May 6, 2020

dhurley14 reviewed May 7, 2020

View reviewed changes

x-pack/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts Outdated Show resolved Hide resolved

dhurley14 approved these changes May 7, 2020

View reviewed changes

Fixed per PR comments

52ed6b0

FrankHassanabad merged commit e3b4b99 into elastic:master May 7, 2020

FrankHassanabad deleted the fix-import-bug branch May 7, 2020 14:06

FrankHassanabad mentioned this pull request May 7, 2020

[7.x] [SIEM][Detection Engine] Fixes import bug with non existent signals index (#65595) #65690

Merged

rylnd mentioned this pull request May 7, 2020

[SIEM][Detections] Rule Import performs unnecessary work when signals index DNE #65565

Closed

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM][Detection Engine] Fixes import bug with non existent signals index #65595

[SIEM][Detection Engine] Fixes import bug with non existent signals index #65595

FrankHassanabad commented May 6, 2020 •

edited

Loading

FrankHassanabad May 6, 2020 •

edited

Loading

FrankHassanabad May 6, 2020

rylnd May 7, 2020

FrankHassanabad May 7, 2020

elasticmachine commented May 6, 2020

dhurley14 left a comment

kibanamachine commented May 7, 2020

elasticmachine commented Sep 23, 2021

[SIEM][Detection Engine] Fixes import bug with non existent signals index #65595

[SIEM][Detection Engine] Fixes import bug with non existent signals index #65595

Conversation

FrankHassanabad commented May 6, 2020 • edited Loading

Checklist

FrankHassanabad May 6, 2020 • edited Loading

Choose a reason for hiding this comment

FrankHassanabad May 6, 2020

Choose a reason for hiding this comment

rylnd May 7, 2020

Choose a reason for hiding this comment

FrankHassanabad May 7, 2020

Choose a reason for hiding this comment

elasticmachine commented May 6, 2020

dhurley14 left a comment

Choose a reason for hiding this comment

kibanamachine commented May 7, 2020

💚 Build Succeeded

History

elasticmachine commented Sep 23, 2021

FrankHassanabad commented May 6, 2020 •

edited

Loading

FrankHassanabad May 6, 2020 •

edited

Loading