Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Improve saved object migrations #66056

Merged
merged 38 commits into from
Sep 29, 2020
Merged

RFC: Improve saved object migrations #66056

merged 38 commits into from
Sep 29, 2020

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented May 11, 2020 •
edited
Loading

Summary

RFC for improving the Saved Objects migration algorithm to ensure a smooth Kibana upgrade
procedure.

Rendered RFC: https://github.com/elastic/kibana/blob/master/rfcs/text/0013_saved_object_migrations.md
Supersedes: #52202

Changelog

See the commit messages for a detailed list of changes.

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects RFC labels May 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@rudolf rudolf force-pushed the rfc-saved-object-migrations branch from 33fe1b4 to 142fa9c Compare May 12, 2020 10:51
@rudolf rudolf force-pushed the rfc-saved-object-migrations branch from 142fa9c to 089e0b0 Compare May 12, 2020 10:58
@rudolf rudolf marked this pull request as ready for review May 12, 2020 12:02
@rudolf rudolf added the release_note:skip Skip the PR/issue when compiling release notes label May 12, 2020
@tylersmalley tylersmalley mentioned this pull request May 13, 2020
Closed
@joshdover
Copy link
Contributor

ack: will review tomorrow

joshdover
joshdover reviewed May 17, 2020
View reviewed changes
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
mshustov
mshustov reviewed May 19, 2020
View reviewed changes
rfcs/text/0013_saved_object_migrations.md Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
pgayvallet
pgayvallet reviewed May 20, 2020
View reviewed changes
rfcs/text/0013_saved_object_migrations.md Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Show resolved Hide resolved
rfcs/text/0013_saved_object_migrations.md Outdated Show resolved Hide resolved
@rudolf rudolf added the RFC/final-comment-period If no concerns are raised in 3 business days this RFC will be accepted label Sep 24, 2020
@rudolf
Copy link
Contributor Author

rudolf commented Sep 24, 2020

With all outstanding concerns being addressed/resolved this RFC is now in the final comment period. If no fundamental concerns are raised, it will be merged on the 29th September.

@rudolf rudolf mentioned this pull request Sep 24, 2020
Closed
@rudolf rudolf merged commit d7d96d9 into elastic:master Sep 29, 2020
@rudolf rudolf deleted the rfc-saved-object-migrations branch September 29, 2020 07:35
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 29, 2020
@gmmorris
Merge branch 'master' into actions/test-connector
4943c44 
* master: (365 commits)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  [Security Solution] Fixes url timeline flaky test (elastic#78556)
  adds retryability feature (elastic#78611)
  Aligns several module versions across the repository (elastic#78327)
  Empty prompt and loading spinner for service map (elastic#78382)
  Change progress bar to spinner (elastic#78460)
  [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111)
  Slim down core bundle (elastic#75912)
  [Alerting] retry internal OCC calls within alertsClient (elastic#77838)
  [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656)
  [Ingest Manager] Ingest setup upgrade (elastic#78081)
  [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520)
  fix name without a category or if field end with .text (elastic#78655)
  [Security Solution] [Detections] Log message enhancements (elastic#78429)
  [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303)
  ...
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-anomalies…
f7e5f99 
…-to-timeline

* 'master' of github.com:elastic/kibana: (22 commits)
  update apm index pattern (elastic#78732)
  78024: move transform out of dataset (elastic#78216)
  [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695)
  [Discover] Make _source field not clickable (elastic#78698)
  [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685)
  [APM] Review feedback from distribution + transaction metrics (elastic#78752)
  [Ingest pipelines] Add ability to stop pipeline simulation  (elastic#78183)
  [CSM] Fix core vital legend background (elastic#78273)
  [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481)
  fix lodash imports (elastic#78456)
  [Maps] Add layer type preview icons (elastic#78650)
  [APM] Use transaction metrics for distribution charts (elastic#78484)
  [Uptime] Ml anomaly alert edit (elastic#76909)
  [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 1, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66056 or prevent reminders by adding the backport:skip label.

@rudolf rudolf mentioned this pull request Oct 1, 2020
Closed
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66056 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66056 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66056 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66056 or prevent reminders by adding the backport:skip label.

@pgayvallet pgayvallet added the backport:skip This commit does not require backporting label Oct 7, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2020
@ppf2 ppf2 mentioned this pull request Oct 13, 2020
Closed
@sorenlouv sorenlouv mentioned this pull request Oct 19, 2020
Closed
@rudolf rudolf mentioned this pull request Oct 20, 2020
Closed
@rudolf rudolf added the project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient label Nov 27, 2020
@rudolf rudolf mentioned this pull request Dec 4, 2020
Merged
7 tasks
@rudolf rudolf mentioned this pull request Dec 14, 2020
Closed
@ymao1 ymao1 mentioned this pull request Jul 13, 2021
Closed
@pgayvallet pgayvallet mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacey-gammon stacey-gammon stacey-gammon left review comments

@mshustov mshustov mshustov left review comments

@pgayvallet pgayvallet pgayvallet left review comments

@timroes timroes timroes left review comments

@sorenlouv sorenlouv sorenlouv left review comments

@tylersmalley tylersmalley tylersmalley left review comments

@joshdover joshdover joshdover approved these changes

@kobelb kobelb kobelb approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Saved Objects project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient release_note:skip Skip the PR/issue when compiling release notes RFC/final-comment-period If no concerns are raised in 3 business days this RFC will be accepted RFC Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.