Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] API integration tests for GET data frame analytics endpoints #66136

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented May 11, 2020

Summary

Part of #63700

Adds API integration tests for:

  • /api/ml/data_frame/analytics

  • /api/ml/data_frame/analytics/{analyticsId}

  • /api/ml/data_frame/analytics/_stats

  • /api/ml/data_frame/analytics/{analyticsId}/_stats

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.8.0 labels May 11, 2020
@alvarezmelissa87 alvarezmelissa87 self-assigned this May 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a few naming suggestions

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit 840ae20 into elastic:master May 12, 2020
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request May 12, 2020
…astic#66136)

* wip: create analytics api integration dir

* add get analytics tests

* update types and naming

* update api test types
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request May 12, 2020
…astic#66136)

* wip: create analytics api integration dir

* add get analytics tests

* update types and naming

* update api test types
@alvarezmelissa87 alvarezmelissa87 deleted the ml-analytics-api-integration-test branch May 12, 2020 20:55
alvarezmelissa87 added a commit that referenced this pull request May 13, 2020
…6136) (#66309)

* wip: create analytics api integration dir

* add get analytics tests

* update types and naming

* update api test types
alvarezmelissa87 added a commit that referenced this pull request May 13, 2020
…6136) (#66310)

* wip: create analytics api integration dir

* add get analytics tests

* update types and naming

* update api test types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants