-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement/better warning for url length #6773
Changes from 2 commits
55db90d
64699aa
4c70d69
1dace5c
8b4ebf5
e308db9
121e4f2
281b38b
116521c
aa030d7
b333c51
133d7e5
8b97881
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -228,6 +228,19 @@ export default function configDefaultsProvider() { | |
value: 5000, | ||
description: 'The time in milliseconds which an information notification ' + | ||
'will be displayed on-screen for. Setting to Infinity will disable.' | ||
} | ||
}, | ||
'url:warnLength': { | ||
value: 1900, | ||
description: ` | ||
When the application url reaches this length we will start warning about | ||
potential issues. Internet Explorer supports urls up to | ||
<a href="https://support.microsoft.com/en-us/kb/208427">2,083 characters</a> long. | ||
If IE compatibility is not important this can probably be disabled (set to 0). | ||
`, | ||
}, | ||
'url:limit': { | ||
value: 2082, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Weren't we seeing IE fail before this point? I thought 2048 was the magic number there... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We were testing the length of the hash, I think... I trust the support doc though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, right, that's the whole URL length... alrighty then. |
||
description: 'When the application url reaches this length we will start to aggressively fail.', | ||
}, | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be used anywhere?