[Ingest Manager] Fix datasource validation for streams without vars #67950
Conversation
nchaulet
added
bug
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
added
the
release_note:skip
| 'with-disabled-streams-disabled': { | ||
| vars: { 'var-name': null }, | ||
| }, | ||
| 'with-disabled-streams-disabled2': {}, |
There was a problem hiding this comment.
Is this an intentional addition, and if yes, can it have a more descriptive name than just the 2 added at the end?
There was a problem hiding this comment.
This works as described, but the error only appears once "Save data source" has been clicked.
When the user first clicks on "Create data source" for the AWS integration, nothing indicates that they need to open the "Collect logs from AWS instances" section and fill in a value for the Queue URL.
So, this works, but I'm not sure if this is the best way to handle it?
|
Yes the error is only showed when we click on"Save data source" I think it's the expected behavior here. cc @jen-huang |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
@skh @nchaulet Yes, that is the expected form validation behavior here and has existed before this PR. The UX rationale is so that there is a response in the UI on a user action, maybe @hbharding can provide better worded elaboration :D |
…ms-column * 'master' of github.com:elastic/kibana: (63 commits) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) Update documentation/examples of deprecated namespaceAgnostic field (elastic#68039) [DOCS] Updates Canvas docs with new menus (elastic#66061) chore(NA): avoids imports of server or public code into common (elastic#67231) [SIEM] Fix GetOneTimeline graphql type (elastic#68137) skip flaky suite (elastic#67838) [Uptime] Add loading message for monitor list no items (elastic#67378) [Ingest Manager] Update indexing strategy docs to use dataset.* (elastic#68068) [Ingest Manager] Fix datasource validation for streams without vars (elastic#67950) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/index.ts # x-pack/plugins/index_management/__jest__/client_integration/home.test.ts # x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts
Summary
Resolve #67938
Fix a type error when we validate a datasource with input variables but no stream variables.
How I fixed this? I added the stream to the validation results even if there is no variables for that stream.
How to test this?
You can try to add|edit the datasource AWS, if you do not put a Queue URL you should have an error otherwise it should work.