Fix setFindTimeout defaults to 10 seconds. #7070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using the same default timeout of 90 seconds (in intern.js) for both how long a test can run, and for how long we try to find an element on the page. This is bad because when we fail to find an element on a page we will always hit the test timeout first, and then we don't get any logging about what element we failed to find.
This change adds a findTimeout of 10 seconds to intern.js and changes all the support/page/*page.js files to use this new findTimeout.
Finally, in settings_page.js, in setAdvancedSettings there was a place that I added an explicit setFindTimeout.