Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setFindTimeout defaults to 10 seconds. #7070

Merged
merged 3 commits into from
Apr 27, 2016
Merged

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Apr 27, 2016

We've been using the same default timeout of 90 seconds (in intern.js) for both how long a test can run, and for how long we try to find an element on the page. This is bad because when we fail to find an element on a page we will always hit the test timeout first, and then we don't get any logging about what element we failed to find.

This change adds a findTimeout of 10 seconds to intern.js and changes all the support/page/*page.js files to use this new findTimeout.

Finally, in settings_page.js, in setAdvancedSettings there was a place that I added an explicit setFindTimeout.

@w33ble
Copy link
Contributor

w33ble commented Apr 27, 2016

kibana/test/support/pages/shield_page.js is still using the defaultTimeout, and should also be changed to the findTimeout. Make that one change, and this LGTM.

@LeeDr LeeDr merged commit 929fe36 into elastic:master Apr 27, 2016
@LeeDr LeeDr removed the v4.6.0 label Apr 28, 2016
@LeeDr LeeDr deleted the fixTestTimeouts branch May 23, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants