Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] change user facing text "Data streams" to "datasets" #70840

Merged
merged 1 commit into from
Jul 6, 2020
Merged

[Ingest Manager] change user facing text "Data streams" to "datasets" #70840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/ingest_manager/public/applications/ingest_manager/constants/page_paths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const PAGE_ROUTING_PATHS = {
fleet_agent_details_events: '/fleet/agents/:agentId',
fleet_agent_details_details: '/fleet/agents/:agentId/details',
fleet_enrollment_tokens: '/fleet/enrollment-tokens',
data_streams: '/data-streams',
data_streams: '/datasets',
};

export const pagePathGetters: {
Expand All @@ -80,5 +80,5 @@ export const pagePathGetters: {
fleet_agent_details: ({ agentId, tabId }) =>
`/fleet/agents/${agentId}${tabId ? `/${tabId}` : ''}`,
fleet_enrollment_tokens: () => '/fleet/enrollment-tokens',
data_streams: () => '/data-streams',
data_streams: () => '/datasets',
};
2 changes: 1 addition & 1 deletion x-pack/plugins/ingest_manager/public/applications/ingest_manager/hooks/use_breadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ const breadcrumbGetters: {
BASE_BREADCRUMB,
{
text: i18n.translate('xpack.ingestManager.breadcrumbs.datastreamsPageTitle', {
defaultMessage: 'Data streams',
defaultMessage: 'Datasets',
}),
},
],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ingest_manager/public/applications/ingest_manager/layouts/default.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export const DefaultLayout: React.FunctionComponent<Props> = ({
<EuiTab isSelected={section === 'data_stream'} href={getHref('data_streams')}>
<FormattedMessage
id="xpack.ingestManager.appNavigation.dataStreamsLinkText"
defaultMessage="Data streams"
defaultMessage="Datasets"
/>
</EuiTab>
</EuiTabs>
Expand Down
10 changes: 5 additions & 5 deletions ...ngest_manager/public/applications/ingest_manager/sections/data_stream/list_page/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const DataStreamListPageLayout: React.FunctionComponent = ({ children }) => (
<h1>
<FormattedMessage
id="xpack.ingestManager.dataStreamList.pageTitle"
defaultMessage="Data streams"
defaultMessage="Datasets"
/>
</h1>
</EuiText>
Expand Down Expand Up @@ -177,7 +177,7 @@ export const DataStreamListPage: React.FunctionComponent<{}> = () => {
<h2>
<FormattedMessage
id="xpack.ingestManager.dataStreamList.noDataStreamsPrompt"
defaultMessage="No data streams"
defaultMessage="No datasets"
/>
</h2>
}
Expand Down Expand Up @@ -220,14 +220,14 @@ export const DataStreamListPage: React.FunctionComponent<{}> = () => {
isLoading ? (
<FormattedMessage
id="xpack.ingestManager.dataStreamList.loadingDataStreamsMessage"
defaultMessage="Loading data streams…"
defaultMessage="Loading datasets…"
/>
) : dataStreamsData && !dataStreamsData.data_streams.length ? (
emptyPrompt
) : (
<FormattedMessage
id="xpack.ingestManager.dataStreamList.noFilteredDataStreamsMessage"
defaultMessage="No matching data streams found"
defaultMessage="No matching datasets found"
/>
)
}
Expand Down Expand Up @@ -257,7 +257,7 @@ export const DataStreamListPage: React.FunctionComponent<{}> = () => {
placeholder: i18n.translate(
'xpack.ingestManager.dataStreamList.searchPlaceholderTitle',
{
defaultMessage: 'Filter data streams',
defaultMessage: 'Filter datasets',
}
),
incremental: true,
Expand Down
6 changes: 3 additions & 3 deletions ...er/public/applications/ingest_manager/sections/overview/components/datastream_section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ export const OverviewDatastreamSection: React.FC = () => {
<h2>
<FormattedMessage
id="xpack.ingestManager.overviewPageDataStreamsPanelTitle"
defaultMessage="Data streams"
defaultMessage="Datasets"
/>
</h2>
</EuiTitle>
<EuiButtonEmpty size="xs" flush="right" href={getHref('data_streams')}>
<FormattedMessage
id="xpack.ingestManager.overviewPageDataStreamsPanelAction"
defaultMessage="View data streams"
defaultMessage="View datasets"
/>
</EuiButtonEmpty>
</header>
Expand All @@ -70,7 +70,7 @@ export const OverviewDatastreamSection: React.FC = () => {
<EuiDescriptionListTitle>
<FormattedMessage
id="xpack.ingestManager.overviewDatastreamTotalTitle"
defaultMessage="Data streams"
defaultMessage="Datasets"
/>
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
Expand Down