-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Data: Report dataset info only if there is known metadata #71419
[Telemetry] Data: Report dataset info only if there is known metadata #71419
Conversation
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@afharo it's FF today. Please merge if possible, otherwise we'll have to bump to 7.10. |
Update: This PR is currently blocked until elastic/elasticsearch#59195 is done. There is no point on checking the metadata to retrieve the |
Replanning for |
@elasticmachine merge upstream |
@TinaHeiligers and @Bamieh! After testing the new Ingest Manager, I noticed we had to add an exception for the way the data-streams actually work and seen by Kibana:
Funny enough: the data-stream works as an alias, so you can get the index That's why in my last commit I had to change it to I'll wait for you to confirm if you are happy with these latest additions :) |
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-core (Team:Core) |
Summary
On top of #64935, this PR adds the collection of the
constant_keyword
sdataset.name
anddataset.type
only if Elastic-known meta fields are found in the index's mappings.We'll collect the information about the
dataset
fields mentioned above only if_meta.beat
(reported asshipper
) exists, or the index is maintained by the new Ingest Manager (it should contain_meta.managed_by === 'ingest-manager' and/or the
_meta.package.name` field).Checklist
Delete any items that are not applicable to this PR.
For maintainers