Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Rename settings.monitoring to agent.monitoring #71467

Merged
merged 3 commits into from
Jul 13, 2020
Merged

[Ingest Manager] Rename settings.monitoring to agent.monitoring #71467

merged 3 commits into from
Jul 13, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Corresponding Fleet PR for elastic/beats#19848. Renames settings.monitoring in full agent yaml to agent.monitoring.

Also, simplifies the downloaded agent config yaml file name to just elastic-agent.yml.

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 13, 2020
@jen-huang jen-huang requested a review from a team July 13, 2020 15:43
@jen-huang jen-huang self-assigned this Jul 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

nchaulet
nchaulet approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@michalpristas
Copy link

testing with agent

michalpristas
michalpristas approved these changes Jul 13, 2020
View reviewed changes
Copy link

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works with agent, thank you so much

@michalpristas michalpristas mentioned this pull request Jul 13, 2020
Merged
6 tasks
@jen-huang jen-huang requested review from a team as code owners July 13, 2020 17:57
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang merged commit 7282597 into elastic:master Jul 13, 2020
@jen-huang jen-huang deleted the ingest/fix/agent-settings-yml branch July 13, 2020 19:46
jen-huang added a commit to jen-huang/kibana that referenced this pull request Jul 13, 2020
@jen-huang
[Ingest Manager] Rename settings.monitoring to agent.monitoring (e…
5604e84 
…lastic#71467)

* Rename settings.monitoring to agent.monitoring; simplify default file name for downloaded agent yaml

* Fix test
@jen-huang jen-huang mentioned this pull request Jul 13, 2020
Merged
jen-huang added a commit that referenced this pull request Jul 13, 2020
@jen-huang
[Ingest Manager] Rename settings.monitoring to agent.monitoring (#…
8ace667 
…71467) (#71527)

* Rename settings.monitoring to agent.monitoring; simplify default file name for downloaded agent yaml

* Fix test
@michalpristas michalpristas mentioned this pull request Jul 14, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees

@jen-huang jen-huang

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jen-huang @elasticmachine @michalpristas @kibanamachine @nchaulet