-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] landing page always being displayed #71494
Merged
cauemarcondes
merged 5 commits into
elastic:master
from
cauemarcondes:obs_hide_landing_page
Jul 14, 2020
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dd3c7d5
hides overview item when no other obs plugin is available.
cauemarcondes 5367a3b
reverting tests changes
cauemarcondes e93d121
reverting tests changes
cauemarcondes 59525da
adding overview to observability tests
cauemarcondes 280e772
Merge branch 'master' of github.com:elastic/kibana into obs_hide_land…
cauemarcondes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
x-pack/plugins/observability/public/toggle_overview_link_in_nav.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
import { CoreStart } from 'kibana/public'; | ||
|
||
import { toggleOverviewLinkInNav } from './toggle_overview_link_in_nav'; | ||
|
||
describe('toggleOverviewLinkInNav', () => { | ||
const update = jest.fn(); | ||
afterEach(() => { | ||
update.mockClear(); | ||
}); | ||
it('hides overview menu', () => { | ||
const core = ({ | ||
application: { | ||
capabilities: { | ||
navLinks: { | ||
apm: false, | ||
logs: false, | ||
metrics: false, | ||
uptime: false, | ||
}, | ||
}, | ||
}, | ||
chrome: { navLinks: { update } }, | ||
} as unknown) as CoreStart; | ||
toggleOverviewLinkInNav(core); | ||
expect(update).toHaveBeenCalledWith('observability-overview', { hidden: true }); | ||
}); | ||
it('shows overview menu', () => { | ||
const core = ({ | ||
application: { | ||
capabilities: { | ||
navLinks: { | ||
apm: true, | ||
logs: false, | ||
metrics: false, | ||
uptime: false, | ||
}, | ||
}, | ||
}, | ||
chrome: { navLinks: { update } }, | ||
} as unknown) as CoreStart; | ||
toggleOverviewLinkInNav(core); | ||
expect(update).not.toHaveBeenCalled(); | ||
}); | ||
}); |
15 changes: 15 additions & 0 deletions
15
x-pack/plugins/observability/public/toggle_overview_link_in_nav.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { CoreStart } from 'kibana/public'; | ||
|
||
export function toggleOverviewLinkInNav(core: CoreStart) { | ||
const { apm, logs, metrics, uptime } = core.application.capabilities.navLinks; | ||
const someVisible = Object.values({ apm, logs, metrics, uptime }).some((visible) => visible); | ||
if (!someVisible) { | ||
core.chrome.navLinks.update('observability-overview', { hidden: true }); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite late, but note that this is a deprecated API:
kibana/src/core/public/chrome/nav_links/nav_links_service.ts
Lines 76 to 82 in bf04235