-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the developer guide #71631
Clean up the developer guide #71631
Conversation
stacey-gammon
commented
Jul 14, 2020
- Use same section title level on all source files
- Change from float to discrete.
eac2cc3
to
c368893
Compare
Pinging @elastic/kibana-docs (Team:Docs) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* rename float to discrete * use same section title level on all source files * Elasticsearch => {es} Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* rename float to discrete * use same section title level on all source files * Elasticsearch => {es} Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
include::rbac.asciidoc[] | ||
include::rbac.asciidoc[leveloffset=+1] | ||
|
||
include::feature-registration.asciidoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stacey-gammon It looks like the "Plugin feature registration" page is missing in the docs for 7.9.
Just noticed it, the file is supposed to be included here in the Architecture » Security page, but it's not being rendered. I traced it back to this PR. Not sure how to fix it though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only went into 7.x (7.10) and master. Didn't backport to 7.9. Looks like it's showing up appropriately in those branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 Sorry, I saw that this one only got backported to 7.10... I thought I checked 7.10 and master in the docs but I guess I got my wires crossed. I think it was because I was searching for "Plugin feature registration" and it didn't show any results for 7.x or master, but it looks like that's intentional.
* rename float to discrete * use same section title level on all source files * Elasticsearch => {es} Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # docs/developer/architecture/index.asciidoc # docs/developer/architecture/security/index.asciidoc # docs/developer/architecture/security/rbac.asciidoc