Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the developer guide #71631

Merged

Conversation

stacey-gammon
Copy link
Contributor

  • Use same section title level on all source files
  • Change from float to discrete.

@stacey-gammon stacey-gammon force-pushed the 2020-07-14-float-to-discrete branch from eac2cc3 to c368893 Compare July 14, 2020 12:48
@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 chore Team:Docs 7.10.0 and removed v7.9.0 labels Jul 14, 2020
@stacey-gammon stacey-gammon requested a review from lcawl July 14, 2020 15:42
@stacey-gammon stacey-gammon marked this pull request as ready for review July 14, 2020 15:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@stacey-gammon stacey-gammon requested a review from KOTungseth July 14, 2020 15:43
@spalger spalger added v7.10.0 and removed 7.10.0 labels Jul 15, 2020
@stacey-gammon
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stacey-gammon stacey-gammon merged commit a20469f into elastic:master Jul 16, 2020
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Jul 16, 2020
* rename float to discrete

* use same section title level on all source files

* Elasticsearch => {es}

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
stacey-gammon added a commit that referenced this pull request Jul 16, 2020
* rename float to discrete

* use same section title level on all source files

* Elasticsearch => {es}

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Comment on lines -12 to +14
include::rbac.asciidoc[]
include::rbac.asciidoc[leveloffset=+1]

include::feature-registration.asciidoc[leveloffset=+1]
Copy link
Contributor

@jportner jportner Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stacey-gammon It looks like the "Plugin feature registration" page is missing in the docs for 7.9.

Just noticed it, the file is supposed to be included here in the Architecture » Security page, but it's not being rendered. I traced it back to this PR. Not sure how to fix it though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only went into 7.x (7.10) and master. Didn't backport to 7.9. Looks like it's showing up appropriately in those branches.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Sorry, I saw that this one only got backported to 7.10... I thought I checked 7.10 and master in the docs but I guess I got my wires crossed. I think it was because I was searching for "Plugin feature registration" and it didn't show any results for 7.x or master, but it looks like that's intentional.

jportner pushed a commit to jportner/kibana that referenced this pull request Sep 8, 2020
* rename float to discrete

* use same section title level on all source files

* Elasticsearch => {es}

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	docs/developer/architecture/index.asciidoc
#	docs/developer/architecture/security/index.asciidoc
#	docs/developer/architecture/security/rbac.asciidoc
jportner added a commit that referenced this pull request Sep 9, 2020
Co-authored-by: Stacey Gammon <gammon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes review Team:Docs v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants