Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float percentiles line chart #71902

Merged
merged 5 commits into from
Jul 20, 2020

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jul 15, 2020

Summary

This PR addresses an issue with the ID parser for the line chart when percentiles have float values.

  • πŸ› Fix for float values series id format
  • βœ… Add tests for the float values scenario

Fixes #47000

Checklist

@dej611 dej611 added Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.10.0 v7.9.0 labels Jul 15, 2020
@dej611 dej611 requested review from spalger and sulemanof July 15, 2020 16:51
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the code in the change, but the fix from the merge bomb that occured in the last PR looks good to me :)

@dej611 dej611 self-assigned this Jul 16, 2020
@dej611 dej611 marked this pull request as ready for review July 16, 2020 07:56
@dej611 dej611 requested a review from a team July 16, 2020 07:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying goodbye to the issue πŸ‘ , fix works
Bildschirmfoto 2020-07-17 um 08 03 01
some questions about the tests before this can be merged

@dej611
Copy link
Contributor Author

dej611 commented Jul 17, 2020

@elasticmachine merge upstream

@dej611 dej611 requested a review from kertal July 17, 2020 14:42
@kertal
Copy link
Member

kertal commented Jul 20, 2020

@elasticmachine merge upstream

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM πŸ‘ , thx for adapting the tests! Bug is fixed, tested in Chrome & Firefox, works.

@kibanamachine
Copy link
Contributor

πŸ’š Build Succeeded

Build metrics

page load bundle size

id value diff baseline
visTypeVislib 1.3MB +125.0B 1.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit a28463d into elastic:master Jul 20, 2020
@dej611 dej611 deleted the fix/float-percentiles-line-chart-2 branch July 20, 2020 08:22
dej611 added a commit to dej611/kibana that referenced this pull request Jul 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dej611 added a commit to dej611/kibana that referenced this pull request Jul 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 20, 2020
* master:
  [Observability] Remove app logos (elastic#72259)
  Fix float percentiles line chart (elastic#71902)
  update chromedriver to 84 (elastic#72228)
  [esArchiver] actually re-delete the .kibana index if we lose recreate race (elastic#72354)
  [Maps] convert SavedGisMap to TS (elastic#72286)
  [DOCS] Removes occurrences of X-Pack Security and Reporting (elastic#72302)
  use WORKSPACE env var for stack_functional_integration tests, fix navigate path (elastic#71908)
  [Monitoring] Fix issue with ES node detail status (elastic#72298)
  [SIEM] Updates consumer in export_rule archive (elastic#72324)
  [kbn/dev-utils] add RunWithCommands utility (elastic#72311)
  [Security Solution][Endpoint][Exceptions] Only write manifest to policy when there are changes (elastic#72000)
  skip flaky suite (elastic#72339)
  [ML] Fix annotations pagination & change labels from letters to numbers (elastic#72204)
  [Lens] Fix switching with layers (elastic#71982)
  [Maps] 7.9 documenation updates (elastic#71893)
  docs: ✏️ add "Explore underlying data" user docs (elastic#70807)
  [Security Solution][Exceptions] - Remove initial add exception item button in builder (elastic#72215)
  Fix indentation level in code exploration doc (elastic#72274)
  register graph usage (elastic#72041)
  [Monitoring] Added a case for Alerting if security/ssl is disabled (elastic#71846)
dej611 added a commit that referenced this pull request Jul 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dej611 added a commit that referenced this pull request Jul 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:XYAxis XY-Axis charts (bar, area, line) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float percentiles in line chart disable line styling
5 participants