Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Error occurrences tooltip not being displayed #72425

Merged
merged 1 commit into from
Jul 21, 2020
Merged

[APM] Error occurrences tooltip not being displayed #72425

merged 1 commit into from
Jul 21, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #72417

error_occurences_fix

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 20, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 20, 2020 12:57
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 3.7MB -25.0B 3.7MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Any idea how long this has been broken ?

@cauemarcondes
Copy link
Contributor Author

Good catch. Any idea how long this has been broken ?

I broke it (😅) while developing the error rate chart.

@cauemarcondes cauemarcondes merged commit efa1795 into elastic:master Jul 21, 2020
@cauemarcondes cauemarcondes deleted the apm-error-tootip branch July 21, 2020 08:09
sorenlouv pushed a commit to sorenlouv/kibana that referenced this pull request Jul 21, 2020
@cauemarcondes
fixing error occurences tooltip (elastic#72425)
96c7b53
@sorenlouv sorenlouv mentioned this pull request Jul 21, 2020
Merged
@sorenlouv
Copy link
Member

💚 Backport successful

The PR was backported to the following branches:

@cauemarcondes cauemarcondes mentioned this pull request Jul 21, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jul 21, 2020
@cauemarcondes
fixing error occurences tooltip (elastic#72425)
2d787a3
@sorenlouv
Copy link
Member

sorenlouv commented Jul 21, 2020 •
edited
Loading

@cauemarcondes fyi: The automatic backporting only created a backport for 7.9 because this PR didn't have the v7.10.0 label. This is necessary for PRs created after feature freeze.

@cauemarcondes
Copy link
Contributor Author

@cauemarcondes fyi: The automatic backporting only created a backport for 7.9 because this PR didn't have the v7.10.0 label. This is necessary for PRs created after feature freeze.

Aaah, got it... thanks for the heads-up

cauemarcondes added a commit that referenced this pull request Jul 21, 2020
@sorenlouv @cauemarcondes
fixing error occurences tooltip (#72425) (#72583)
93f3eed 
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
cauemarcondes added a commit that referenced this pull request Jul 21, 2020
@cauemarcondes
fixing error occurences tooltip (#72425) (#72586)
912e78e
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 21, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
407b09a 
* master: (28 commits)
  allow some env settings for ingest manager (elastic#72544)
  Add inspector for VEGA (elastic#70941)
  chore(NA): fix grunt task for test:coverage (elastic#72539)
  Archive e2e test results in ES (elastic#72575)
  preserve 401 errors from new es client (elastic#71248)
  [SIEM][Detections] Updates text for severity and risk_score overrides  (elastic#72244)
  fixing error occurences tooltip (elastic#72425)
  use KibanaClient interface instead of Client for new client interface (elastic#72388)
  [APM] Handle ML errors (elastic#72316)
  [Discover] Improve histogram tests (elastic#72235)
  [ftr/webdriver] retry on all errors, use Rx so that timers are canceled (elastic#72540)
  [pre-req] Move .storybook to storybook; standardize files (elastic#72384)
  [Security_Solution][Resolver][Bug]: Restore breadcrumb background (elastic#72538)
  [ML] Fix annotation detector linking & delayed_data(0) (elastic#72468)
  [Security Solution][Exceptions] - Make esTypes and subType available to index patterns (elastic#72336)
  [SIEM] Uses faster wait from testing-library and removes duplicate older wait idiom (elastic#72509)
  Fix long combo box items breaking out of flex item width (elastic#72512)
  [pipeline/commitStatus] update commit status in baseline-capture job (elastic#72366)
  [Security Solution][Resolver] Update the resolver element ref on scroll events if the position of the element has changed within the page (elastic#72461)
  [Maps] auto-fit to data bounds (elastic#72129)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 21, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
8545f64 
…feature-privileges

* alerting/consumer-based-rbac: (30 commits)
  removed uneeded tests
  expclude security wrapper in SO client passed to ActionsClient
  allow some env settings for ingest manager (elastic#72544)
  Add inspector for VEGA (elastic#70941)
  chore(NA): fix grunt task for test:coverage (elastic#72539)
  Archive e2e test results in ES (elastic#72575)
  preserve 401 errors from new es client (elastic#71248)
  [SIEM][Detections] Updates text for severity and risk_score overrides  (elastic#72244)
  fixing error occurences tooltip (elastic#72425)
  use KibanaClient interface instead of Client for new client interface (elastic#72388)
  [APM] Handle ML errors (elastic#72316)
  [Discover] Improve histogram tests (elastic#72235)
  [ftr/webdriver] retry on all errors, use Rx so that timers are canceled (elastic#72540)
  [pre-req] Move .storybook to storybook; standardize files (elastic#72384)
  [Security_Solution][Resolver][Bug]: Restore breadcrumb background (elastic#72538)
  [ML] Fix annotation detector linking & delayed_data(0) (elastic#72468)
  [Security Solution][Exceptions] - Make esTypes and subType available to index patterns (elastic#72336)
  [SIEM] Uses faster wait from testing-library and removes duplicate older wait idiom (elastic#72509)
  Fix long combo box items breaking out of flex item width (elastic#72512)
  [pipeline/commitStatus] update commit status in baseline-capture job (elastic#72366)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Error occurrences tooltip not being displayed
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv