-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
32 characters requirement for xpack.reporting.encryptionKey #72593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey
toby-sutor
added a commit
that referenced
this pull request
Jul 21, 2020
Similar to #72593 document that the string needs to be at least 32 characters long.
toby-sutor
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Jul 21, 2020
KOTungseth
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
KOTungseth
pushed a commit
that referenced
this pull request
Jul 28, 2020
Similar to #72593 document that the string needs to be at least 32 characters long.
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72594) Similar to elastic#72593 document that the string needs to be at least 32 characters long.
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72594) Similar to elastic#72593 document that the string needs to be at least 32 characters long.
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72594) Similar to elastic#72593 document that the string needs to be at least 32 characters long.
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72594) Similar to elastic#72593 document that the string needs to be at least 32 characters long.
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72594) Similar to elastic#72593 document that the string needs to be at least 32 characters long.
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72593) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72593) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72593) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72593) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey
KOTungseth
pushed a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 28, 2020
…72593) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
…73470) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey Co-authored-by: Toby Sutor <55087308+toby-sutor@users.noreply.github.com>
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
…73471) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey Co-authored-by: Toby Sutor <55087308+toby-sutor@users.noreply.github.com>
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
…73469) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey Co-authored-by: Toby Sutor <55087308+toby-sutor@users.noreply.github.com>
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
…73472) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey Co-authored-by: Toby Sutor <55087308+toby-sutor@users.noreply.github.com>
KOTungseth
added a commit
that referenced
this pull request
Jul 28, 2020
…73473) Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey Co-authored-by: Toby Sutor <55087308+toby-sutor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey
See https://github.com/elastic/sdh-kibana/issues/399#issuecomment-615120888 for reference.