Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding api test for transaction_groups /breakdown and /avg_duration_by_browser #72623

Merged
merged 7 commits into from
Jul 22, 2020
Merged

Adding api test for transaction_groups /breakdown and /avg_duration_by_browser #72623

merged 7 commits into from
Jul 22, 2020

Conversation

cauemarcondes
Copy link
Contributor

No description provided.

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Jul 21, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 21, 2020 13:00
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 21, 2020
@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #72623 opened]

  • Start Time: 2020-07-21T13:01:30.369+0000

  • Duration: 26 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

sorenlouv
sorenlouv requested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You most likely shouldn't remove transactionType and tranactionName

@cauemarcondes cauemarcondes requested a review from sorenlouv July 21, 2020 15:41
@cauemarcondes
Copy link
Contributor Author

You most likely shouldn't remove transactionType and tranactionName

I put the transactionName back and added an API test for it.

@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 4dcf719 into elastic:master Jul 22, 2020
@cauemarcondes cauemarcondes deleted the apm-transaction-breakdown-api-test branch July 22, 2020 13:01
kibanamachine pushed a commit that referenced this pull request Jul 22, 2020
@cauemarcondes @elasticmachine
Adding api test for transaction_groups /breakdown and /avg_duration_b…
5d261ee 
…y_browser (#72623)

* adding api test for transaction_groups /breakdown and /avg_duration_by_browser

* adding filter by transaction name

* adding filter by transaction name

* addressing pr comments

* fixing TS issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 22, 2020
Merged
kibanamachine pushed a commit that referenced this pull request Jul 22, 2020
@cauemarcondes @elasticmachine
Adding api test for transaction_groups /breakdown and /avg_duration_b…
e392bdb 
…y_browser (#72623)

* adding api test for transaction_groups /breakdown and /avg_duration_by_browser

* adding filter by transaction name

* adding filter by transaction name

* addressing pr comments

* fixing TS issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 22, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

The PR was backported to the following branches:

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 22, 2020
@gmmorris
Merge branch 'master' into alerting/management-feature-privileges
7c51753 
* master: (34 commits)
  Adds Role Based Access-Control to the Alerting & Action plugins based on Kibana Feature Controls (elastic#67157)
  [Monitoring] Revert direct shipping code (elastic#72505)
  Use server basepath  when creating reporting jobs (elastic#72722)
  Adding api test for transaction_groups /breakdown and /avg_duration_by_browser (elastic#72623)
  [Task Manager] Addresses flaky test introduced by buffered store (elastic#72815)
  [Observability] filter "hasData" api by processor event (elastic#72810)
  do  not pass title as part of tsvb request (elastic#72619)
  [Lens] Legend config (elastic#70619)
  Stabilize closing toast (elastic#72097)
  stabilize failing test (elastic#72086)
  Stabilize filter bar test (elastic#72032)
  Unskip vislib tests (elastic#71452)
  [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689)
  fix preAuth/preRouting mocks (elastic#72663)
  [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788)
  [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584)
  [Security Solution] Fixes exception modal not loading content (elastic#72770)
  [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748)
  [Detections] Add validation for Threshold value field (elastic#72611)
  [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730)
  ...
cauemarcondes added a commit that referenced this pull request Jul 22, 2020
@kibanamachine @cauemarcondes @elasticmachine
Adding api test for transaction_groups /breakdown and /avg_duration_b…
49fe603 
…y_browser (#72623) (#72839)

* adding api test for transaction_groups /breakdown and /avg_duration_by_browser

* adding filter by transaction name

* adding filter by transaction name

* addressing pr comments

* fixing TS issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cauemarcondes added a commit that referenced this pull request Jul 22, 2020
@kibanamachine @cauemarcondes @elasticmachine
Adding api test for transaction_groups /breakdown and /avg_duration_b…
45eb60a 
…y_browser (#72623) (#72840)

* adding api test for transaction_groups /breakdown and /avg_duration_by_browser

* adding filter by transaction name

* adding filter by transaction name

* addressing pr comments

* fixing TS issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cauemarcondes @apmmachine @sorenlouv @kibanamachine @elasticmachine