If elasticsearch plugin is not ready, do not block

[ycombinator]

Fixes #7278.

[epixa]

@bevacqua What do you think about this?

[bevacqua]

Doesn't make much sense to me. What is Kibana without ES?

[epixa]

The issue that needs to be resolved is that when Kibana is running without ES, the user should see the status page with elasticsearch marked as red. Since the config changes, requests to Kibana when ES is unavailable just hang.

[bevacqua]

Got it. In that case this makes sense. We should set the user value to {} for consistency, anyhow.

[ycombinator]

We should set the user value to {} for consistency, anyhow.

Hey @bevacqua and @epixa, thanks for the review and discussion. Please note that I actually changed the code in this PR a bit. The check for whether ES is ready or not is now done on the side of the code calling the uiSettings.getUserProvided() method, not within that method itself. I think this is cleaner because there may be scenarios when we want to legitimately wait on uiSettings.getUserProvided(). Thoughts?

[bevacqua]

@ycombinator That's the code I looked at (your latest version) -- I think we need something like this:

const red = server.plugins.elasticsearch.status.state === 'red';
payload.uiSettings.user =  red ? {} : await uiSettings.getUserProvided();

That way we don't break the assumption that uiSettings.user is an object -- even if we're not currently using it for anything other than the status page.

[ycombinator]

Sounds good. Will change. Thanks.

[ycombinator]

@bevacqua This is ready for a (hopefully quick and final) review. Thanks again for reviewing, especially on your day off.

[bevacqua]

Much awesome. LGTM 🎉