[Uptime] Use manual intervals for ping histogram #72928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elastic/uptime#215 Prior to this we'd get too few buckets in some ranges.
andrewvc
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
|
Could we be dropping the most recent bucket?
We are getting a bucket in the result set:
It looks like you haven't touched the client code, so this could be a separate bug. |
|
@justinkambic I think that's unrelated. I just fixed the tests, they did some unnecessarily specific assertions about bucket size. IMHO that's not necessary. |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
justinkambic
approved these changes
Jul 23, 2020
| @@ -63,7 +48,12 @@ export const getPingHistogram: UMElasticsearchQueryFn< | |||
| size: 0, | |||
| aggs: { | |||
| timeseries: { | |||
| ...seriesHistogram, | |||
| date_histogram: { | |||
There was a problem hiding this comment.
One thing that might be nice is to add two tests to ensure that the query we generate is providing the expected fixed_interval value. We have "test coverage" here, but I don't think the params are ever validated by a test. I could write this test in a follow-up, I don't think we need to do it here.
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Jul 24, 2020
* [Uptime] Use manual intervals for ping histogram Fixes elastic/uptime#215 Prior to this we'd get too few buckets in some ranges. * Update test fixtures, remove overly-specific checks * Remove unused import
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Jul 24, 2020
* [Uptime] Use manual intervals for ping histogram Fixes elastic/uptime#215 Prior to this we'd get too few buckets in some ranges. * Update test fixtures, remove overly-specific checks * Remove unused import
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 27, 2020
* master: (111 commits) Remove flaky note from gauge tests (elastic#73240) Convert functional vega tests to ts and unskip tests (elastic#72238) [Graph] Unskip graph tests (elastic#72291) Add default Elasticsearch credentials to docs (elastic#72617) [APM] Read body from indicesStats in upload-telemetry-data (elastic#72732) The directory in the command was missing the /generated directory and would cause all definitions to be regenerated in the wrong place. (elastic#72766) [KP] use new ES client in SO service (elastic#72289) [Security Solution][Exceptions] Prevents value list entries from co-existing with non value list entries (elastic#72995) Return EUI CSS to Shareable Runtime (elastic#72990) Removed useless karma test (elastic#73190) [INGEST_MANAGER] Make package config name blank for endpoint on Package Config create (elastic#73082) [Ingest Manager] Support DEGRADED state in fleet agent event (elastic#73104) [Security Solution][Detections] Change detections breadcrumb title (elastic#73059) [ML] Fixing unnecessary deleting job polling (elastic#73087) [ML] Fixing recognizer wizard create job button (elastic#73025) [Composable template] Preview composite template (elastic#72598) [Uptime] Use manual intervals for ping histogram (elastic#72928) [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (elastic#73130) [Maps] fix tile layer attibution text and attribution link validation errors (elastic#73160) skip ingest pipeline api tests ...
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
andrewvc
added a commit
that referenced
this pull request
Jul 29, 2020
Fixes elastic/uptime#215 Prior to this we'd get too few buckets in some ranges.
andrewvc
added a commit
that referenced
this pull request
Jul 29, 2020
* [Uptime] Use manual intervals for ping histogram Fixes elastic/uptime#215 Prior to this we'd get too few buckets in some ranges. * Update test fixtures, remove overly-specific checks * Remove unused import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes elastic/uptime#215
Prior to this we'd get too few buckets in some ranges.