Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Functional test ] Increase the waiting time for the filter bar request #73424

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[ Functional test ] Increase the waiting time for the filter bar request #73424

merged 1 commit into from
Jul 28, 2020

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jul 28, 2020

Summary

This PR contains a fix for a flaky test suggested by @timroes in this issue here.
With a timeout of 10s the filter bar request manage to complete and firefox tests are all passing now.
Flaky test runner suite passing - configured for 100 executions for the firefox group.

Closes #70295

Checklist

@dej611 dej611 added Feature:Input Control Input controls visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Jul 28, 2020
@dej611 dej611 self-assigned this Jul 28, 2020
timroes
timroes approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and makes sense

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 marked this pull request as ready for review July 28, 2020 12:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611 dej611 merged commit 8c710aa into elastic:master Jul 28, 2020
@dej611 dej611 deleted the fix/70295 branch July 28, 2020 12:21
@dej611 dej611 mentioned this pull request Jul 28, 2020
Merged
dej611 added a commit to dej611/kibana that referenced this pull request Jul 28, 2020
@dej611
[ Functional test ] Increase the waiting time for the filter bar requ…
682f942 
…est (elastic#73424)
@dej611 dej611 mentioned this pull request Jul 28, 2020
Merged
dej611 added a commit to dej611/kibana that referenced this pull request Jul 28, 2020
@dej611
[ Functional test ] Increase the waiting time for the filter bar requ…
a63cde9 
…est (elastic#73424)
@dej611 dej611 linked an issue Jul 28, 2020 that may be closed by this pull request
Failing test: Firefox UI Functional Tests.test/functional/apps/visualize/input_control_vis/chained_controls·js - visualize app input controls chained controls should disable child control when parent control is not set #68472
Closed
@dej611 dej611 mentioned this pull request Jul 28, 2020
Closed
dej611 added a commit that referenced this pull request Jul 28, 2020
@dej611
[7.x] [ Functional test ] Increase the waiting time for the filter ba…
7585460 
…r request (#73424) (#73437)
dej611 added a commit that referenced this pull request Jul 28, 2020
@dej611
[7.9] [ Functional test ] Increase the waiting time for the filter ba…
ac66e87 
…r request (#73424) (#73438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees

@dej611 dej611

Labels
Feature:Input Control Input controls visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@dej611 @kibanamachine @elasticmachine @timroes