Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (#73349) #73616

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

yctercero
Copy link
Contributor

Backports the following commits to 7.x:

…ude exception list list_id (elastic#73349)

## Summary

This PR addresses the following:
- Adds `list_id` to `rule.exceptions_list` - this is needed in a number of features
- Updated `getExceptions` in `x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.ts` to use the latest exception item find endpoint that accepts an array of lists (previously was looping through lists and conducting a `find` for each)
- Updated prepackaged rule that makes reference to global endpoint list to include `list_id`
- Updates `formatAboutStepData` in `x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/create/helpers.ts` to include exception list `list_id`
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +113.0B 7.3MB

page load bundle size

id value diff baseline
securitySolution 870.9KB +111.0B 870.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spong spong merged commit 5e51c4b into elastic:7.x Jul 29, 2020
@yctercero yctercero deleted the backport/7.x/pr-73349 branch October 14, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants