Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer #73745

Merged
merged 3 commits into from
Jul 30, 2020
Merged

[Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer #73745

merged 3 commits into from
Jul 30, 2020

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jul 29, 2020 •
edited
Loading

Summary

Small PR updating how nested entries are displayed in exception viewer. Doesn't change anything functionally, just cosmetic.

Before

Screen Shot 2020-07-29 at 5 20 27 PM

After

Screen Shot 2020-07-29 at 5 38 19 PM

Checklist

@yctercero yctercero requested review from a team as code owners July 29, 2020 21:42
@yctercero yctercero self-assigned this Jul 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero yctercero added v7.9.1 and removed v7.9.0 labels Jul 30, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +432.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

FrankHassanabad
FrankHassanabad approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Small fixes are always feel good PR's after all the heavy lifting. Thanks!

@yctercero yctercero merged commit 744afce into elastic:master Jul 30, 2020
@yctercero yctercero mentioned this pull request Jul 30, 2020
Merged
yctercero added a commit to yctercero/kibana that referenced this pull request Jul 30, 2020
@yctercero
[Security Solution][Exceptions] - Update how nested entries are displ…
c01aa75 
…ayed in exceptions viewer (elastic#73745)

### Summary

Small PR updating how nested entries are displayed in exception viewer. Doesn't change anything functionally, just cosmetic.
yctercero added a commit to yctercero/kibana that referenced this pull request Jul 30, 2020
@yctercero
[Security Solution][Exceptions] - Update how nested entries are displ…
6e7d77a 
…ayed in exceptions viewer (elastic#73745)

### Summary

Small PR updating how nested entries are displayed in exception viewer. Doesn't change anything functionally, just cosmetic.
@yctercero yctercero mentioned this pull request Jul 30, 2020
Merged
@spong spong added v7.9.0 and removed v7.9.1 labels Jul 30, 2020
yctercero added a commit that referenced this pull request Jul 30, 2020
@yctercero
[Security Solution][Exceptions] - Update how nested entries are displ…
8108ed0 
…ayed in exceptions viewer (#73745) (#73891)

### Summary

Small PR updating how nested entries are displayed in exception viewer. Doesn't change anything functionally, just cosmetic.
yctercero added a commit that referenced this pull request Jul 30, 2020
@yctercero
[Security Solution][Exceptions] - Update how nested entries are displ…
6b968cd 
…ayed in exceptions viewer (#73745) (#73896)

### Summary

Small PR updating how nested entries are displayed in exception viewer. Doesn't change anything functionally, just cosmetic.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 31, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
28b1676 
* master: (54 commits)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  [Security Solution][Detections] Change from sha1 to sha256 (elastic#73741)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 31, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
ce2ee00 
* master: (38 commits)
  [Discover] Context unskip date nanos functional tests (elastic#73781)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  ...
@yctercero yctercero deleted the viewer_nested branch October 14, 2020 11:59
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees

@yctercero yctercero

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yctercero @elasticmachine @kibanamachine @FrankHassanabad @MindyRS @spong