Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fixes scroll issues related to the sticky header #74062

Merged
merged 12 commits into from
Aug 4, 2020

Conversation

andrew-goldstein
Copy link
Contributor

[Security Solution] Fixes scroll issues related to the sticky header

Fixes scrolling issues related to the sticky header.

The Security solution hid the app navigation links (e.g. Overview, Detections, Hosts ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent 7.9 BCs, sometimes this created issues while scrolling.

With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)

Fixes: #73882

Desk testing

Desk tested in:

  • Chrome 84.0.4147.105
  • Firefox 79.0
  • Safari 13.1.2

@andrew-goldstein andrew-goldstein added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Aug 3, 2020
@andrew-goldstein andrew-goldstein requested review from a team as code owners August 3, 2020 07:28
@andrew-goldstein andrew-goldstein self-assigned this Aug 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](elastic#73882).

With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)

Fixes: elastic#73882

Desk tested in:
- Chrome `84.0.4147.105`
- Firefox `79.0`
- Safari `13.1.2`
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have paired together on the zoom and tested the solution and LGTM! Thank you @andrew-goldstein for taking care of that issue 💪 🟢 merge, backport and enjoy your 🌴

@andrew-goldstein
Copy link
Contributor Author

Thanks for your skill and help with this PR @patrykkopycinski!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 2026 -7 2033

async chunks size

id value diff baseline
securitySolution 7.3MB -16.4KB 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this pull request Aug 4, 2020
…lastic#74062)

## [Security Solution] Fixes scroll issues related to the sticky header

Fixes scrolling issues related to the sticky header.

The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](elastic#73882).

With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)

Fixes: elastic#73882

## Desk testing

Desk tested in:
- Chrome `84.0.4147.105`
- Firefox `79.0`
- Safari `13.1.2`
andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this pull request Aug 4, 2020
…lastic#74062)

## [Security Solution] Fixes scroll issues related to the sticky header

Fixes scrolling issues related to the sticky header.

The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](elastic#73882).

With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)

Fixes: elastic#73882

## Desk testing

Desk tested in:
- Chrome `84.0.4147.105`
- Firefox `79.0`
- Safari `13.1.2`
andrew-goldstein added a commit that referenced this pull request Aug 4, 2020
…74062) (#74208)

## [Security Solution] Fixes scroll issues related to the sticky header

Fixes scrolling issues related to the sticky header.

The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](#73882).

With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)

Fixes: #73882

## Desk testing

Desk tested in:
- Chrome `84.0.4147.105`
- Firefox `79.0`
- Safari `13.1.2`
andrew-goldstein added a commit that referenced this pull request Aug 4, 2020
…74062) (#74207)

## [Security Solution] Fixes scroll issues related to the sticky header

Fixes scrolling issues related to the sticky header.

The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](#73882).

With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)

Fixes: #73882

## Desk testing

Desk tested in:
- Chrome `84.0.4147.105`
- Firefox `79.0`
- Safari `13.1.2`
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0
Projects
None yet
5 participants