Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Fix typo on view selector in metrics explorer #74084

Merged
merged 1 commit into from
Aug 3, 2020
Merged

[Metrics UI] Fix typo on view selector in metrics explorer #74084

merged 1 commit into from
Aug 3, 2020

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Aug 3, 2020

Summary

Fixes a typo in the view selector in the metrics explorer

Screenshot 2020-08-03 at 16 24 17

Checklist

Delete any items that are not applicable to this PR.

@afgomez afgomez added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Aug 3, 2020
@afgomez afgomez requested a review from a team as a code owner August 3, 2020 14:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
infra 3.6MB +1.0B 3.6MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker self-requested a review August 3, 2020 16:14
simianhacker
simianhacker approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afgomez afgomez merged commit 909c982 into elastic:master Aug 3, 2020
@afgomez afgomez deleted the fix-typo branch August 3, 2020 16:27
This was referenced Aug 3, 2020
Merged
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request Aug 3, 2020
[Metrics UI] Fix typo on view selector in metrics explorer (elastic#7…
7f53c3b 
…4084)
afgomez pushed a commit that referenced this pull request Aug 3, 2020
[7.x] [Metrics UI] Fix typo on view selector in metrics explorer (#74084
5f371ea 
) (#74119)
afgomez pushed a commit that referenced this pull request Aug 3, 2020
[7.9] [Metrics UI] Fix typo on view selector in metrics explorer (#74084
788bc5b 
) (#74120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afgomez @elasticmachine @kibanamachine @simianhacker