EMT-661: use new metadata current #74394
Conversation
nnamdifrankie
added
v7.10.0
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
# Conflicts: # x-pack/test/ingest_manager_api_integration/config.ts
|
|
||
| import { Client } from '@elastic/elasticsearch'; | ||
|
|
||
| export async function putTransform(getService: (serviceName: 'es') => Client, transformId: string) { |
There was a problem hiding this comment.
It looks like we put this transform in to get the tests to pass, which is good. However, I pulled this down and tried it out and the UI breaks without this transform.
Can we put the transform in in the interim before it's available via the package? I don't want to UI to break indefinitely before there's a package available.
Let me know if I'm missing something.
There was a problem hiding this comment.
This is good for getting things set up for the transform and new index, however I want to wait on merging this in until it's in a state that it won't break the UI.
Is it possible to add the transform in another way until it's possible to ship it with the package? Similar to the way it's added in the tests?
Let me know if I'm missing anything
# Conflicts: # x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
|
@elasticmachine test this |
|
Hi Neptunium, do you have a minute to review my bug fix? |
|
@elasticmachine merge upstream |
# Conflicts: # x-pack/plugins/ingest_manager/server/services/epm/packages/remove.ts
| @@ -79,7 +79,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |||
| await testSubjects.exists('emptyPolicyTable'); | |||
| }); | |||
|
|
|||
| it('finds data after load and polling', async () => { | |||
| it.skip('finds data after load and polling', async () => { | |||
There was a problem hiding this comment.
We can rework this test. For polling, it would probably make sense to load data directly in the destination index to ensure that we update the UI correctly. We could break it out to another, isolated integration test where we can load data to the destination index to test this particular case. Alternatively, we get the transform to run more quickly for the test, but that sounds non-trivial.
We can try this out in another PR IMO.
FYI @paul-tavares let me know your thoughts
There was a problem hiding this comment.
@kevinlog To cut down cost I suggest that we move this to when data is loaded. I believe you were trying to test the timer refresh?
x-pack/plugins/ingest_manager/server/services/epm/elasticsearch/transform/install.ts
Outdated
Show resolved
Hide resolved
…form, clean up tests
|
Thanks for doing this! Installing the transforms looks good and happy with the changes made. Tested and works. |
|
Checked it out and it works with UI Real endpoint shows up, transform gets created as expected Destination index getting docs: Loaded in 100 more, Endpoints showed up with transform running: 🎉 🚢 |
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
… installation (elastic#74394) [SecuritySolution-Ingest]: use new metadata current and add transform installation
Summary
https://github.com/elastic/endpoint-app-team/issues/661
#75153
https://github.com/elastic/security-team/issues/72
Checklist
Delete any items that are not applicable to this PR.