changing lodash

.eslintrc.js

@@ -1295,5 +1295,46 @@ module.exports = {
         '@typescript-eslint/prefer-ts-expect-error': 'error',
       },
     },
+    {
+      files: [
+        '**/public/**/*.{js,mjs,ts,tsx}',
+        '**/common/**/*.{js,mjs,ts,tsx}',
+        'packages/**/*.{js,mjs,ts,tsx}',
+      ],
+      rules: {
+        'no-restricted-imports': [
+          'error',
+          {
+            paths: [
+              {
+                name: 'lodash',
+                message: 'Please import specific method as a file instead, e.g. "lodash/get"',
+              },
+            ],
+          },
+        ],
+      },
+    },
+    {
+      files: [
+        '**/public/**/*.{js,mjs,ts,tsx}',
+        '**/common/**/*.{js,mjs,ts,tsx}',
+        'packages/**/*.{js,mjs,ts,tsx}',
+      ],
+      rules: {
+        'no-restricted-imports': [
+          'warn',
+          {
+            paths: [
+              {
+                name: 'lodash',
+                importNames: ['_'],
+                message: 'Prefer importing individual modules, e.g. import get from "lodash/get"',
+              },
+            ],
+          },
+        ],
+      },
+    },
   ],
 };

examples/alerting_example/public/alert_types/astros.tsx

@@ -30,7 +30,7 @@ import {
   EuiTextColor,
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import { flatten } from 'lodash';
+import flatten from 'lodash/flatten';
 import { ALERTING_EXAMPLE_APP_ID, Craft, Operator } from '../../common/constants';
 import { SanitizedAlert } from '../../../../x-pack/plugins/alerts/common';
 import { PluginSetupContract as AlertingSetup } from '../../../../x-pack/plugins/alerts/public';

examples/alerting_example/public/components/view_alert.tsx

@@ -31,7 +31,7 @@ import {
 } from '@elastic/eui';
 import { withRouter, RouteComponentProps } from 'react-router-dom';
 import { CoreStart } from 'kibana/public';
-import { isEmpty } from 'lodash';
+import isEmpty from 'lodash/isEmpty';
 import {
   Alert,
   AlertTaskState,

examples/alerting_example/public/components/view_astros_alert.tsx

@@ -33,7 +33,7 @@ import {
 } from '@elastic/eui';
 import { withRouter, RouteComponentProps } from 'react-router-dom';
 import { CoreStart } from 'kibana/public';
-import { isEmpty } from 'lodash';
+import isEmpty from 'lodash/isEmpty';
 import {
   Alert,
   AlertTaskState,

packages/kbn-config-schema/src/internals/index.ts

@@ -27,7 +27,7 @@ import {
   ValidationErrorItem,
   ValidationOptions,
 } from 'joi';
-import { isPlainObject } from 'lodash';
+import isPlainObject from 'lodash/isPlainObject';
 import { isDuration } from 'moment';
 import { Stream } from 'stream';
 import { ByteSizeValue, ensureByteSizeValue } from '../byte_size_value';

packages/kbn-es-archiver/src/lib/__tests__/stats.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { uniq } from 'lodash';
+import uniq from 'lodash/uniq';
 import sinon from 'sinon';
 import expect from '@kbn/expect';
 import { ToolingLog } from '@kbn/dev-utils';

packages/kbn-es-archiver/src/lib/docs/__tests__/stubs.ts

@@ -20,8 +20,7 @@
 import { Client } from 'elasticsearch';
 import sinon from 'sinon';
 import Chance from 'chance';
-import { times } from 'lodash';
-
+import times from 'lodash/times';
 import { Stats } from '../../stats';
 
 const chance = new Chance();

packages/kbn-es-archiver/src/lib/indices/delete_index.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { get } from 'lodash';
+import get from 'lodash/get';
 import { Client } from 'elasticsearch';
 import { ToolingLog } from '@kbn/dev-utils';
 import { Stats } from '../stats';

packages/kbn-es-archiver/src/lib/stats.ts

@@ -18,7 +18,7 @@
  */
 
 import { ToolingLog } from '@kbn/dev-utils';
-import { cloneDeep } from 'lodash';
+import cloneDeep from 'lodash/cloneDeep';
 
 export interface IndexStats {
   skipped: boolean;

packages/kbn-interpreter/src/common/lib/arg.js

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { includes } from 'lodash';
+import includes from 'lodash/includes';
 
 export function Arg(config) {
   if (config.name === '_') throw Error('Arg names must not be _. Use it in aliases instead.');

packages/kbn-interpreter/src/common/lib/fn.js

@@ -17,7 +17,8 @@
  * under the License.
  */
 
-import { mapValues, includes } from 'lodash';
+import mapValues from 'lodash/mapValues';
+import includes from 'lodash/includes';
 import { Arg } from './arg';
 
 export function Fn(config) {

packages/kbn-interpreter/src/common/lib/registry.js

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { clone } from 'lodash';
+import clone from 'lodash/clone';
 
 export class Registry {
   constructor(prop = 'name') {

packages/kbn-pm/src/test_helpers/absolute_path_snapshot_serializer.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { cloneDeepWith } from 'lodash';
+import cloneDeepWith from 'lodash/cloneDeepWith';
 import { resolve, sep as pathSep } from 'path';
 
 const repoRoot = resolve(__dirname, '../../../../');

packages/kbn-telemetry-tools/src/tools/check_collector__integrity.test.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { cloneDeep } from 'lodash';
+import cloneDeep from 'lodash/cloneDeep';
 import * as ts from 'typescript';
 import { parsedWorkingCollector } from './__fixture__/parsed_working_collector';
 import { checkCompatibleTypeDescriptor, checkMatchingMapping } from './check_collector_integrity';

packages/kbn-telemetry-tools/src/tools/check_collector_integrity.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { reduce } from 'lodash';
+import reduce from 'lodash/reduce';
 import { difference, flattenKeys, pickDeep } from './utils';
 import { ParsedUsageCollection } from './ts_parser';
 import { generateMapping, compatibleSchemaTypes } from './manage_schema';

packages/kbn-telemetry-tools/src/tools/serializer.ts

@@ -18,7 +18,7 @@
  */
 
 import * as ts from 'typescript';
-import { uniq } from 'lodash';
+import uniq from 'lodash/uniq';
 import {
   getResolvedModuleSourceFile,
   getIdentifierDeclarationFromSource,

packages/kbn-telemetry-tools/src/tools/utils.ts

@@ -18,7 +18,15 @@
  */
 
 import * as ts from 'typescript';
-import { pick, isObject, each, isArray, reduce, isEmpty, merge, transform, isEqual } from 'lodash';
+import pick from 'lodash/pick';
+import isObject from 'lodash/isObject';
+import each from 'lodash/each';
+import isArray from 'lodash/isArray';
+import reduce from 'lodash/reduce';
+import isEmpty from 'lodash/isEmpty';
+import merge from 'lodash/merge';
+import transform from 'lodash/transform';
+import isEqual from 'lodash/isEqual';
 import * as path from 'path';
 import glob from 'glob';
 import { readFile, writeFile } from 'fs';

packages/kbn-test/src/functional_test_runner/lib/config/config.ts

@@ -18,8 +18,10 @@
  */
 
 import { Schema } from 'joi';
-import { cloneDeepWith, get, has, toPath } from 'lodash';
-
+import cloneDeepWith from 'lodash/cloneDeepWith';
+import get from 'lodash/get';
+import has from 'lodash/has';
+import toPath from 'lodash/toPath';
 import { schema } from './schema';
 
 const $values = Symbol('values');

packages/kbn-test/src/functional_test_runner/lib/config/read_config_file.ts

@@ -18,8 +18,7 @@
  */
 
 import { ToolingLog } from '@kbn/dev-utils';
-import { defaultsDeep } from 'lodash';
-
+import defaultsDeep from 'lodash/defaultsDeep';
 import { Config } from './config';
 import { transformDeprecations } from './transform_deprecations';
 

packages/kbn-test/src/legacy_es/legacy_es_test_cluster.js

@@ -19,7 +19,8 @@
 
 import { resolve } from 'path';
 import { format } from 'url';
-import { get, toPath } from 'lodash';
+import get from 'lodash/get';
+import toPath from 'lodash/toPath';
 import { Cluster } from '@kbn/es';
 import { CI_PARALLEL_PROCESS_PREFIX } from '../ci_parallel_process_prefix';
 import { esTestConfig } from './es_test_config';

packages/kbn-ui-framework/src/components/table/listing_table/listing_table.js

@@ -21,7 +21,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 import _ from 'lodash';
-
 import { KuiListingTableToolBar } from './listing_table_tool_bar';
 import { KuiListingTableToolBarFooter } from './listing_table_tool_bar_footer';
 import { KuiListingTableRow } from './listing_table_row';

packages/kbn-ui-framework/src/components/table/listing_table/listing_table_row.js

@@ -21,7 +21,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 import _ from 'lodash';
-
 import { KuiTableRow, KuiTableRowCell, KuiTableRowCheckBoxCell } from '../';
 
 import { LEFT_ALIGNMENT, RIGHT_ALIGNMENT } from '../../../services';

src/cli/cluster/cluster_manager.test.ts

@@ -32,7 +32,6 @@ jest.mock('readline', () => ({
 const mockConfig: any = {};
 
 import { sample } from 'lodash';
-
 import { ClusterManager, SomeCliArgs } from './cluster_manager';
 import { Worker } from './worker';
 

src/cli/serve/read_keystore.js

@@ -18,7 +18,6 @@
  */
 
 import { set } from '@elastic/safer-lodash-set';
-
 import { Keystore } from '../../legacy/server/keystore';
 import { getKeystore } from '../../cli_keystore/get_keystore';
 

src/cli_keystore/cli_keystore.js

@@ -18,7 +18,6 @@
  */
 
 import _ from 'lodash';
-
 import { pkg } from '../core/server/utils';
 import Command from '../cli/command';
 import { Keystore } from '../legacy/server/keystore';

src/core/public/chrome/doc_title/doc_title_service.ts

@@ -17,7 +17,9 @@
  * under the License.
  */
 
-import { compact, flattenDeep, isString } from 'lodash';
+import compact from 'lodash/compact';
+import flattenDeep from 'lodash/flattenDeep';
+import isString from 'lodash/isString';
 
 interface StartDeps {
   document: { title: string };

src/core/public/chrome/nav_controls/nav_controls_service.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { sortBy } from 'lodash';
+import sortBy from 'lodash/sortBy';
 import { BehaviorSubject, ReplaySubject, Observable } from 'rxjs';
 import { map, takeUntil } from 'rxjs/operators';
 import { MountPoint } from '../../types';

src/core/public/chrome/nav_links/nav_links_service.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { sortBy } from 'lodash';
+import sortBy from 'lodash/sortBy';
 import { BehaviorSubject, combineLatest, Observable, ReplaySubject } from 'rxjs';
 import { map, takeUntil } from 'rxjs/operators';
 

src/core/public/chrome/recently_accessed/persisted_log.ts

@@ -17,7 +17,9 @@
  * under the License.
  */
 
-import { cloneDeep, isEqual, take } from 'lodash';
+import cloneDeep from 'lodash/cloneDeep';
+import isEqual from 'lodash/isEqual';
+import take from 'lodash/take';
 import * as Rx from 'rxjs';
 import { map } from 'rxjs/operators';
 

src/core/public/chrome/ui/header/collapsible_nav.tsx

@@ -29,7 +29,8 @@ import {
   EuiText,
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import { groupBy, sortBy } from 'lodash';
+import groupBy from 'lodash/groupBy';
+import sortBy from 'lodash/sortBy';
 import React, { Fragment, useRef } from 'react';
 import { useObservable } from 'react-use';
 import * as Rx from 'rxjs';

src/core/public/http/fetch.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { omitBy } from 'lodash';
+import omitBy from 'lodash/omitBy';
 import { format } from 'url';
 import { BehaviorSubject } from 'rxjs';
 

src/core/public/injected_metadata/injected_metadata_service.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { get } from 'lodash';
+import get from 'lodash/get';
 import { DiscoveredPlugin, PluginName } from '../../server';
 import {
   EnvironmentMode,

src/core/public/overlays/banners/priority_map.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { sortBy } from 'lodash';
+import sortBy from 'lodash/sortBy';
 
 interface PriorityValue {
   readonly priority: number;

src/core/public/plugins/plugin_context.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { omit } from 'lodash';
+import omit from 'lodash/omit';
 import { DiscoveredPlugin } from '../../server';
 import { PluginOpaqueId, PackageInfo, EnvironmentMode } from '../../server/types';
 import { CoreContext } from '../core_system';

src/core/public/plugins/plugins_service.test.ts

@@ -17,7 +17,8 @@
  * under the License.
  */
 
-import { omit, pick } from 'lodash';
+import omit from 'lodash/omit';
+import pick from 'lodash/pick';
 
 import {
   MockedPluginInitializer,

src/core/public/saved_objects/saved_objects_client.ts

@@ -17,7 +17,9 @@
  * under the License.
  */
 
-import { cloneDeep, pick, throttle } from 'lodash';
+import cloneDeep from 'lodash/cloneDeep';
+import pick from 'lodash/pick';
+import throttle from 'lodash/throttle';
 import { resolve as resolveUrl } from 'url';
 
 import {

src/core/public/saved_objects/simple_saved_object.ts

@@ -18,7 +18,8 @@
  */
 
 import { set } from '@elastic/safer-lodash-set';
-import { get, has } from 'lodash';
+import get from 'lodash/get';
+import has from 'lodash/has';
 import { SavedObject as SavedObjectType } from '../../server';
 import { SavedObjectsClientContract } from './saved_objects_client';