-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] enabling logging.verbose depends on silent and quiet settings being false #74827
Conversation
…ttings set to false.
Pinging @elastic/kibana-docs (Team:Docs) |
Probably needs all the backports to maintained versions as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -304,7 +304,7 @@ list of timezones, refer to https://en.wikipedia.org/wiki/List_of_tz_database_ti | |||
|
|||
| [[logging-verbose]] `logging.verbose:` {ece-icon} | |||
| Set to `true` to log all events, including system usage information and all | |||
requests. *Default: `false`* | |||
requests. Requires `logging.silent` and `logging.quiet` set to `false`. *Default: `false`* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it also be worth adding a note to logging.quiet
that it requires logging.silent
to be true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I can be clearer here, but if either logging.silent
or logging.quiet
are set to true
then also setting logging.verbose
to true
will result in Kibana failing to start. Put another way, the logging.verbose
setting is mutually exclusive to these other two settings.
Separately, I don't think if logging.silent
is true
then logging.quiet
also needs to be true
or vice-versa to avoid issues, but I can also test this in case it's another dependency.
We might indicate the opposite configuration in the docs for these other two settings if you want to use them then you need to ensure verbose is false, which should cover warning for this startup failure scenario from the context of these two different groups of settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other suggestion but LGTM
@elasticmachine merge upstream |
jenkins, test this |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
We don't document this setting anymore since it's been deprecated. Going to close this. |
For reference: #84363 |
Summary
Doc fix to mention
logging.verbose
requires silent/quiet logging settings to be false or Kibana will fail to startChecklist
For maintainers