Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file upload] lazy load to reduce page load size #74967

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 13, 2020

file upload plugin adds about 700KB to kibana's initial load size. This PR shrinks that down

@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 13, 2020
@nreese nreese requested a review from kindsun August 13, 2020 16:24
@nreese nreese requested a review from a team as a code owner August 13, 2020 16:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
fileUpload 29 +1 28

async chunks size

id value diff baseline
fileUpload 722.2KB ⚠️ +722.2KB 0.0B
maps 3.3MB +1.3KB 3.3MB
total +723.5KB

page load bundle size

id value diff baseline
fileUpload 9.3KB -716.5KB 725.8KB
maps 288.3KB +395.0B 287.9KB
total -716.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! really nice size reduction. good catch!

  • code review

@nreese nreese merged commit 187a130 into elastic:master Aug 14, 2020
nreese added a commit to nreese/kibana that referenced this pull request Aug 14, 2020
* [file upload] lazy load to reduce page load size

* tslint
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 14, 2020
* master:
  Fix bug on TopN weird behavior with zero values (elastic#74942)
  [Lens] Fix table sorting bug (elastic#74902)
  [SECURITY_SOLUTION] Retry on ingest setup (elastic#75000)
  [file upload] lazy load to reduce page load size (elastic#74967)
  Drilldowns for TSVB / Vega / Timelion (elastic#74848)
  [EventLog] Populate alert instances view with event log data (elastic#68437)
  [UiActions] pass trigger into action execution context (elastic#74363)
nreese added a commit that referenced this pull request Aug 14, 2020
* [file upload] lazy load to reduce page load size

* tslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants