Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds route option for requireDefaultIndex #7516

Merged
merged 5 commits into from
Jun 22, 2016

Conversation

tylersmalley
Copy link
Contributor

With the addition of routes that need to be available when an index pattern is not defined, it makes sense declare it on the route. Previously we used a regular expression that was set within Kibana. This allows plugins to create routes which do not require an index.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley changed the title WIP: Adds route option for requireDefaultIndex Adds route option for requireDefaultIndex Jun 21, 2016
@tylersmalley
Copy link
Contributor Author

In response to #7481

@Bargs
Copy link
Contributor

Bargs commented Jun 21, 2016

IMO it should be opt in. Index patterns are going to be less and less relevant to the app as a whole as we add more plugins.

Either way, the management landing page itself needs to be accessible without a default index pattern otherwise users won't know how to get to security and such.

Tyler Smalley added 2 commits June 21, 2016 09:16
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

The landing page no longer requires an index pattern either. Requiring a default index is now opt-in.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@Bargs
Copy link
Contributor

Bargs commented Jun 22, 2016

For dashboard, discover, and visualize, do you think we should set requireDefaultIndex: true as a default for all sub-routes, like it's done for the indices route:

uiRoutes
.defaults(/management\/kibana\/indices/, {
  resolve: indexPatternsResolutions,
  requireDefaultIndex: true
});

@Bargs
Copy link
Contributor

Bargs commented Jun 22, 2016

Were the html and css changes intentional? Just making sure they weren't committed on accident.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

@Bargs, I moved the requireDefaultIndex requirements for dashboard, discover, and visualize to the defaults as suggested.

The CSS and HTML changes were intentional. There were failing tests on the Advanced Settings page which was due to the actions being off screen because the table was not responsive.

clickPath: function (path) {
return this.remote.findDisplayedByCssSelector('[kbn-href="#/management/' + path + '"]').click();
clickLinkText: function (text) {
return this.remote.findDisplayedByLinkText(text).click();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched to using the linked text because some paths have trailing slashes and it overall made the interface more predictable.

@Bargs
Copy link
Contributor

Bargs commented Jun 22, 2016

LGTM

@Bargs
Copy link
Contributor

Bargs commented Jun 22, 2016

@tylersmalley can you port this to the new alpha4 branch jbudz just created as well when you merge? https://github.com/elastic/kibana/tree/5.0.0-alpha4

@tylersmalley tylersmalley merged commit b4c3991 into elastic:master Jun 22, 2016
@tylersmalley
Copy link
Contributor Author

@Bargs, thanks - will backport to the branch.

elastic-jasper added a commit that referenced this pull request Jun 22, 2016
---------

**Commit 1:**
Adds route option for requireDefaultIndex

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Original sha: 78279de
* Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-06-21T03:48:59Z

**Commit 2:**
Don't require an index for the management landing page

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Original sha: 70b75f1
* Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-06-21T16:16:02Z

**Commit 3:**
Requiring an index pattern for a route is opt-in

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Original sha: a5220c0
* Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-06-21T16:30:06Z

**Commit 4:**
Resolves tests for management redirect changes

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Original sha: 14ef797
* Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-06-22T06:36:35Z

**Commit 5:**
Require index for all routes under {discover,visualize,dashboard}

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Original sha: af84452
* Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-06-22T20:50:22Z
tylersmalley added a commit that referenced this pull request Jun 22, 2016
@epixa epixa added v5.0.0 and removed v5.0.0 labels Aug 1, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
…pattern

Adds route option for requireDefaultIndex

Former-commit-id: b4c3991
cee-chen added a commit that referenced this pull request Feb 20, 2024
`v93.0.0` ⏩ `v93.1.1`

---

## [`v93.1.1`](https://github.com/elastic/eui/releases/v93.2.0)

**This is a patch release primarily intended for use by Kibana.**

- Added top-level `EuiTreeView.Item` export
([#7526](elastic/eui#7526))

## [`v93.1.0`](https://github.com/elastic/eui/releases/v93.1.0)

- Added `index` glyph to `EuiIcon`
([#7498](elastic/eui#7498))
- Updated `EuiHighlight` to accept an array of `search` strings, which
allows highlighting multiple, separate words within its children. This
new type and behavior *only* works if `highlightAll` is also set to
true. ([#7496](elastic/eui#7496))
- Updated `EuiContextMenu` with a new `panels.items.renderItem`
property, which allows rendering completely custom items next to
standard `EuiContextMenuItem` objects
([#7510](elastic/eui#7510))
- `EuiSuperDatePicker` updates:
- Updated `EuiSuperDatePicker` with a new `refreshIntervalUnits` prop.
Passing this prop allows controlling and overriding the default unit
rounding behavior. ([#7501](elastic/eui#7501))
- Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new
`intervalUnits` prop. Passing this prop allows controlling and
overriding the default unit rounding behavior.
([#7501](elastic/eui#7501))
- Updated `onRefreshChange` to pass back a new `intervalUnits` key that
contains the current interval unit format (seconds, minutes, or hours).
([#7501](elastic/eui#7501))
- Updated `EuiSuperDatePicker` with a new `canRoundRelativeUnits` prop,
which defaults to true (current behavior). To preserve displaying the
unit that users select for relative time, set this to false.
([#7502](elastic/eui#7502))
- Updated `EuiSuperDatePicker` with a new `refreshMinInterval` prop,
which accepts a minimum number in milliseconds
([#7516](elastic/eui#7516))
- Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new
`minInterval` prop, which accepts a minimum number in milliseconds
([#7516](elastic/eui#7516))

**Bug fixes**

- Fixed `EuiHighlight` to not parse `search` strings as regexes
([#7496](elastic/eui#7496))
- Fixed `EuiSuperDatePicker` submit bug when used within `<form>`
elements ([#7504](elastic/eui#7504))
- Fixed an `EuiTreeView` bug where `aria-expanded` was being applied to
items without expandable children
([#7513](elastic/eui#7513))

**CSS-in-JS conversions**

- Converted `EuiTreeView` to Emotion. Updates as part of the conversion:
([#7513](elastic/eui#7513))
  - Removed `.euiTreeView__wrapper` div node
  - Enforced consistent `icon` size based on `display` size
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
`v93.0.0` ⏩ `v93.1.1`

---

## [`v93.1.1`](https://github.com/elastic/eui/releases/v93.2.0)

**This is a patch release primarily intended for use by Kibana.**

- Added top-level `EuiTreeView.Item` export
([elastic#7526](elastic/eui#7526))

## [`v93.1.0`](https://github.com/elastic/eui/releases/v93.1.0)

- Added `index` glyph to `EuiIcon`
([elastic#7498](elastic/eui#7498))
- Updated `EuiHighlight` to accept an array of `search` strings, which
allows highlighting multiple, separate words within its children. This
new type and behavior *only* works if `highlightAll` is also set to
true. ([elastic#7496](elastic/eui#7496))
- Updated `EuiContextMenu` with a new `panels.items.renderItem`
property, which allows rendering completely custom items next to
standard `EuiContextMenuItem` objects
([elastic#7510](elastic/eui#7510))
- `EuiSuperDatePicker` updates:
- Updated `EuiSuperDatePicker` with a new `refreshIntervalUnits` prop.
Passing this prop allows controlling and overriding the default unit
rounding behavior. ([elastic#7501](elastic/eui#7501))
- Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new
`intervalUnits` prop. Passing this prop allows controlling and
overriding the default unit rounding behavior.
([elastic#7501](elastic/eui#7501))
- Updated `onRefreshChange` to pass back a new `intervalUnits` key that
contains the current interval unit format (seconds, minutes, or hours).
([elastic#7501](elastic/eui#7501))
- Updated `EuiSuperDatePicker` with a new `canRoundRelativeUnits` prop,
which defaults to true (current behavior). To preserve displaying the
unit that users select for relative time, set this to false.
([elastic#7502](elastic/eui#7502))
- Updated `EuiSuperDatePicker` with a new `refreshMinInterval` prop,
which accepts a minimum number in milliseconds
([elastic#7516](elastic/eui#7516))
- Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new
`minInterval` prop, which accepts a minimum number in milliseconds
([elastic#7516](elastic/eui#7516))

**Bug fixes**

- Fixed `EuiHighlight` to not parse `search` strings as regexes
([elastic#7496](elastic/eui#7496))
- Fixed `EuiSuperDatePicker` submit bug when used within `<form>`
elements ([elastic#7504](elastic/eui#7504))
- Fixed an `EuiTreeView` bug where `aria-expanded` was being applied to
items without expandable children
([elastic#7513](elastic/eui#7513))

**CSS-in-JS conversions**

- Converted `EuiTreeView` to Emotion. Updates as part of the conversion:
([elastic#7513](elastic/eui#7513))
  - Removed `.euiTreeView__wrapper` div node
  - Enforced consistent `icon` size based on `display` size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants