Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Disable Overview view links for analytics jobs with no results #75740

Merged
merged 1 commit into from
Aug 24, 2020
Merged

[ML] Disable Overview view links for analytics jobs with no results #75740

merged 1 commit into from
Aug 24, 2020

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Aug 24, 2020 •
edited
Loading

Summary

Disables the 'View results' links on the Overview page for data frame analytics jobs which don't have results. The tooltip of the link indicates the reason why the link has been disabled. Fixes regression introduced by #74499.

image

Checklist

Delete any items that are not applicable to this PR.

@peteharverson peteharverson requested a review from a team as a code owner August 24, 2020 11:31
@peteharverson peteharverson self-assigned this Aug 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB +2.9KB 8.2MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peteharverson peteharverson merged commit d5a6984 into elastic:master Aug 24, 2020
@peteharverson peteharverson deleted the ml-overview-disable-dfa-view branch August 24, 2020 15:12
peteharverson added a commit to peteharverson/kibana that referenced this pull request Aug 24, 2020
@peteharverson
[ML] Disable Overview view links for analytics jobs with no results (e…
1ee75c4 
…lastic#75740)
@peteharverson peteharverson mentioned this pull request Aug 24, 2020
Merged
@peteharverson peteharverson added release_note:skip Skip the PR/issue when compiling release notes and removed v7.9.1 release_note:fix labels Aug 24, 2020
peteharverson added a commit that referenced this pull request Aug 24, 2020
@peteharverson
[ML] Disable Overview view links for analytics jobs with no results (#…
f0ce720 
…75740) (#75769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@peteharverson peteharverson

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @kibanamachine @walterra @alvarezmelissa87