Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core UI] Kibana Overview Page #75827

Merged
merged 37 commits into from
Oct 6, 2020
Merged

[Core UI] Kibana Overview Page #75827

merged 37 commits into from
Oct 6, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Aug 24, 2020

Summary

Blocked by #70571.
Closes #61549.
Closes #76510.

This adds a getting started page and an overview page that highlights Kibana apps.

Getting Started (without index patterns)

All features available

Screen Shot 2020-10-05 at 11 49 13 AM

OSS

Screen Shot 2020-10-05 at 12 23 27 PM

Overview Page (With index patterns)

All features available

Screen Shot 2020-10-05 at 11 47 53 AM

OSS

Screen Shot 2020-10-05 at 12 23 54 PM

Notable changes

  • Exposes createNewsFeed$ in Newsfeed plugin start to allow other plugins to subscribe to a specific Elastic Newsfeed API endpoint (see https://github.com/elastic/newsfeeds)
  • Fixed Update OSS text for Kibana card on the new home page #76510. Only dashboard and discover descriptions are shown in the Kibana solution card on the home page in OSS
  • Added PageFooter and PageHeader components to kibana-react plugin to allow other overview/landing pages to use the same header and footer shown on the home and Kibana overview pages

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexfrancoeur
Copy link

@ryankeairns @cqliu1 I'm not sure what the current state is exactly here, but we're starting to make progress on the Kibana analytics news feed

@cqliu1 cqliu1 force-pushed the kibana-overview branch 3 times, most recently from 7842407 to e8bf950 Compare September 22, 2020 16:02
@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 22, 2020

This is looking really sharp. Only a few things to report on after an initial pass:

  1. We'll need to add the Kibana logo to the Overview plugin registration so that it shows up in search. (Catherine is already on top of this one).

Screen Shot 2020-09-22 at 1 56 12 PM

  1. I know @MichaelMarcialis mentioned a forthcoming design pass, so I'll just point out this one minor issue. When you have a single solution card, this happens:

Screen Shot 2020-09-22 at 1 50 37 PM

  1. We have a bit of a strange situation with Visualize in terms of when to hide the Kibana 'solution'. We've decided to not display Visualize on the Overview page - instead elevating the Dashboard-first experience - so when it is the only Kibana app you have access to, then you end up with an overview page like:

Screen Shot 2020-09-22 at 1 52 32 PM

and a home page like:

Screen Shot 2020-09-22 at 1 53 02 PM

Admittedly, it's an edge case that a user would only have access to Visualize, so while I don't think we should invest too much effort into the design, we could probably tighten this up a bit. For example, some quick fixes might be:

  • hide the Overview page if you only have access to Visualize, and
  • remove the extra spacing on the home page

@alexfrancoeur , et al, any other thoughts on the Viz-only experience?

@cqliu1
Copy link
Contributor Author

cqliu1 commented Sep 22, 2020

  1. We'll need to add the Kibana logo to the Overview plugin registration so that it shows up in search. (Catherine is already on top of this one).

The Kibana logo's in there now 👍

Screen Shot 2020-09-22 at 1 01 24 PM

@alexfrancoeur
Copy link

The page is looking great @cqliu1 ! Some quick feedback, thoughts and comments below.

  • I'd be interested in hearing @ryankeairns and @MichaelMarcialis thoughts but for the empty data view, I'm not sure if we need any other CTA outside of "Begin by adding data". More specifically, we probably don't need the add data, manage, dev tools, app directory and customize homepage options. It feels like we only need one CTA that in future releases, will be guided by a product tour.
  • Similarly, the app directory and customize home page don't feel right when there is data. I can't recall if they were in the original mockups, but I don't know if either are necessary when in context of the Kibana applications
  • I'm on a 13in MacBook with 1440 x 900 resolution in Chrome. I'm wondering if the cards should be more responsive or if we should aim to have more above the fold. The solution overview pages have more content, but here's a comparison
    image
    image
    image
  • Related, it's quite a scroll to get to the Kibana news feed, and maybe this is something we can discuss during the next design sync on this page. Technically, I think we need to make sure we handle offline scenarios for the newsfeed. What happens if there is no external access to the newsfeed? And we need to support the kibana.yml setting newsfeed.enabled (https://www.elastic.co/guide/en/kibana/current/settings.html). If this is set to false, we'll need to handle it. Either with an error or removal of the feed completely.
  • We now have an endpoint for this feed specifically. I'll need to work with @dsmith001 on populating this, but we may want to update the endpoint before we merge.
  • If only one solution is available, we have a really big card. Should this have a max size?
    image
  • If all solutions are disabled, the stack cards look great. Confirmed that they work with roles as well.

@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 23, 2020

I'd be interested in hearing @ryankeairns and @MichaelMarcialis thoughts but for the empty data view, I'm not sure if we need any other CTA outside of "Begin by adding data". More specifically, we probably don't need the add data, manage, dev tools, app directory and customize homepage options. It feels like we only need one CTA that in future releases, will be guided by a product tour.
Similarly, the app directory and customize home page don't feel right when there is data. I can't recall if they were in the original mockups, but I don't know if either are necessary when in context of the Kibana applications

I agree that Dev Tools and Settings don't seem like a fit and are likely carryovers from the home page header. In order to keep the header consistent between the no data and has data states, I would propose just removing those two and keeping Add data visible in both cases.

As for the footer and the two links down there, I would keep it for a couple of reasons 1) for consistency but more importantly in my opinion 2) for visual reasons. Without the footer that blue button will be floating in space making the page feel unfinished. The footer visually frames the important content and, at least for me, makes the CTA more noticeable.

@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 23, 2020

Related, it's quite a scroll to get to the Kibana news feed, and maybe this is something we can discuss during the next design sync on this page. Technically, I think we need to make sure we handle offline scenarios for the newsfeed. What happens if there is no external access to the newsfeed? And we need to support the kibana.yml setting newsfeed.enabled (https://www.elastic.co/guide/en/kibana/current/settings.html). If this is set to false, we'll need to handle it. Either with an error or removal of the feed completely.

I question whether we need to handle that config setting for this feed. Technically, this is a different feed and I don't believe the other solution overview pages hide their feeds based upon this. I could see us possibly providing a separate config option (e.g. newsfeed_overview_kibana.enabled, but my personal preference, for now, would be to just adapt the layout if the fetch cannot be completed. In other words, if the feed can't be reached, then just hide that column altogether and stretch the solution cards.

cc:/ @MichaelMarcialis @alexfrancoeur

@cqliu1
Copy link
Contributor Author

cqliu1 commented Sep 23, 2020

I agree that Dev Tools and Settings don't seem like a fit and are likely carryovers from the home page header. In order to keep the header consistent between the no data and has data states, I would propose just removing those two and keeping Add data visible in both cases.

Wouldn't it be redundant to have both the Add data button up top and the main Add your data button below? They both link to the same place

Actually, Add data leads to the tutorial directory and Add your data leads to index management. I think it's slightly confusing to have both.

Screen Shot 2020-09-23 at 12 51 49 PM

@ryankeairns
Copy link
Contributor

Actually, Add data leads to the tutorial directory and Add your data leads to index management. I think it's slightly confusing to have both.

Ah yeah, I forgot they went to separate places and agree that it is likely to be confusing having two similarly worded calls-to-action that go to different places. I'm good with only showing 'Add data' on the has data version.

@alexfrancoeur
Copy link

I question whether we need to handle that config setting for this feed. Technically, this is a different feed and I don't believe the other solution overview pages hide their feeds based upon this. I could see us possibly providing a separate config option (e.g. newsfeed_overview_kibana.enabled, but my personal preference, for now, would be to just adapt the layout if the fetch cannot be completed. In other words, if the feed can't be reached, then just hide that column altogether and stretch the solution cards.

I agree with the personal preference here, that works for me. That being said, I'm pretty sure the security solution uses this setting (based on this PR and earlier discussions). I'm not sure about observability, but it should. If it's too much work for the MVP that's fine, but we should support eventually (and probably check in on the observability feed).

As for the footer and the two links down there, I would keep it for a couple of reasons 1) for consistency but more importantly in my opinion 2) for visual reasons. Without the footer that blue button will be floating in space making the page feel unfinished. The footer visually frames the important content and, at least for me, makes the CTA more noticeable.

If we are thinking about keeping these for a more appealing visual design, I'm wondering if we can make a few adjustments. While we all know I'd like to get rid of this app directory, it feels like it makes less sense on this page. The home page is the home page for all applications, I'm not sure how relevant it is here as the focus is on the Kibana apps. I'm OK with keeping this link for changing the home page, but maybe we can make it or action-specific to the Kibana homepage itself. "make this my homepage" kind of thing.

Ah yeah, I forgot they went to separate places and agree that it is likely to be confusing having two similarly worded calls-to-action that go to different places. I'm good with only showing 'Add data' on the has data version.

+1

@MichaelMarcialis
Copy link
Contributor

I'd be interested in hearing @ryankeairns and @MichaelMarcialis thoughts but for the empty data view, I'm not sure if we need any other CTA outside of "Begin by adding data". More specifically, we probably don't need the add data, manage, dev tools, app directory and customize homepage options. It feels like we only need one CTA that in future releases, will be guided by a product tour.

I agree with @ryankeairns regarding dropping the add data, manage, and dev tools links from the pre-data landing page, but keeping the footer links. Am I correct in assuming that add data, manage, and dev tools will come back once data is present?

Similarly, the app directory and customize home page don't feel right when there is data. I can't recall if they were in the original mockups, but I don't know if either are necessary when in context of the Kibana applications

If possible, I'd ideally like to keep them and collect some telemetry on their usage. In addition to @ryankeairns' comments about consistency and framing, my hope was that all landing/overview pages across all solutions will share this same commonality, allowing users to quickly set a landing page as their new post-login route, or see the full breadth of applications that we offer.

However, @alexfrancoeur, you're correct in noting that the currently implemented link to modify your post-login route is not correct. The original design intent was that when viewing a landing/overview page that is not currently your post-login route (such as this one), it should show a one-click option to make it your new post-login route. Only when the page is the current post-login route should we offer that generic link to modify your route settings. Examples can be found in the Figma mockups. @cqliu1, is this something we can easily change?

I'm on a 13in MacBook with 1440 x 900 resolution in Chrome. I'm wondering if the cards should be more responsive or if we should aim to have more above the fold. The solution overview pages have more content, but here's a comparison

Related, it's quite a scroll to get to the Kibana news feed, and maybe this is something we can discuss during the next design sync on this page. Technically, I think we need to make sure we handle offline scenarios for the newsfeed. What happens if there is no external access to the newsfeed? And we need to support the kibana.yml setting newsfeed.enabled (https://www.elastic.co/guide/en/kibana/current/settings.html). If this is set to false, we'll need to handle it. Either with an error or removal of the feed completely.

Having the smaller app cards appear partially below the fold doesn't bother me so much, as the use cases between the Kibana landing page and the Security and Observability overview pages are fairly different. In the Kibana landing page's case, the goal is more focused on what is possible and guiding users to the appropriate app for their needs (rather than delivering critical information as quickly as possible). As long as the page appears scrollable, I think we're OK.

That said, if you strongly disagree and would prefer for the secondary solutions not to appear partially below the fold on smaller screens, a few quick possible come to mind that we can discuss:

  1. We could potentially alter the card illustrations' image ratio (currently 16:9) in order to further reduce the vertical real estate taken by each card.
  2. We could consider moving the news feed up and adjacent to the app cards section, which will reduce the width and height of those contained cards. Originally, we placed the Kibana news feed at the bottom because it was thought to be an overall lower user priority, but it added a desired degree of timeliness to the page (i.e. a reason to come back). However, based on your comments above, perhaps you feel there is more value to it than we originally thought. Let me know what you think.

If only one solution is available, we have a really big card. Should this have a max size?

Yes, this is a bug. I'll be cutting a PR between now and early next week that will address this.

@ryankeairns
Copy link
Contributor

We could consider moving the news feed up and adjacent to the app cards section, which will reduce the width and height of those contained cards.

That's an interesting idea and would be simple way to get additional alignment with the other Overview pages.

@alexfrancoeur
Copy link

That is an interesting idea, is it too late to try out? A quick mock might be a good way to solidify the idea?

We do want to start thinking about how this page could evolve as far as content goes (post-MVP), so it's possible it may be more than just additional navigation.

@cqliu1
Copy link
Contributor Author

cqliu1 commented Sep 29, 2020

Related, it's quite a scroll to get to the Kibana news feed, and maybe this is something we can discuss during the next design sync on this page. Technically, I think we need to make sure we handle offline scenarios for the newsfeed. What happens if there is no external access to the newsfeed? And we need to support the kibana.yml setting newsfeed.enabled (elastic.co/guide/en/kibana/current/settings.html). If this is set to false, we'll need to handle it. Either with an error or removal of the feed completely.

I question whether we need to handle that config setting for this feed. Technically, this is a different feed and I don't believe the other solution overview pages hide their feeds based upon this. I could see us possibly providing a separate config option (e.g. newsfeed_overview_kibana.enabled, but my personal preference, for now, would be to just adapt the layout if the fetch cannot be completed. In other words, if the feed can't be reached, then just hide that column altogether and stretch the solution cards.

I did some refactoring, and with the way it's implemented now, the overview page uses a service provided by the news feed plugin to retrieve the news feed, so it does support the newsfeed.enabled setting and will hide the news section if the news feed plugin is not available.

Side note: If you set the i18n locale to anything besides English, the news feed won't show because the translations aren't provided by the news feed API. Is it okay that the news section will always be hidden for other languages, or do we want to show the articles in English regardless of locale? It looks like the global nav news is also empty, so I assume we just want this section hidden.

Created kivana_overview plugin

Removed test from home plugin

Added CSS

Fixed page header links

Added news feed

Fixed spacers between news items

[Core UI] Kibana Overview Page Style Tweaks (#76712)

Fixed link to index management

Added solution cards to kibana landing page

Added solution links

Fixed ts errors

Using publishReplay() to support multiple consumers in newsfeed plugin

Added createNewsFeed$ to newsfeed plugin start

Added tests

Removed unnecessary export

Hides overview link when other Kibana apps are not available

Added icon to overview plugin

Removed question mark from news feed title

Updated plugin-list

Fixed i18n errors

Revert snapshot

Updated getting started page copy

Hide news feed when no news feed results

Disables Kibana overview page when kibana apps are unavailable

Updated snapshots

Refactor to use KibanaContextProvider

Fixed security tests

Fixed newsfeed api test

Moved overview_footer and overview_header to kibana-react plugin

[Core UI] Kibana Overview Page Style Fixes (#78677)
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like app arch got pinged because of the PageHeader and PageFooter components which were added to the kibana_react package. I just have one question on that:

Added PageFooter and PageHeader components to kibana-react plugin to allow other overview/landing pages to use the same header and footer shown on the home and Kibana overview pages

If these components exist only for overview/landing pages, I would vote for exporting them directly from the kibana_overview plugin instead. This feels like the most logical domain for components that are for use in overview pages. (If you want to create your own overview page that looks similar to the global Kibana overview page, you'd expect to be able to find what you need in kibana_overview).

If there's a reason we really need to keep them in kibana_react, I would vote to name them something much more specific so folks understand their purpose in absence of a logical domain. (LandingPageHeader? IDK)

@cqliu1
Copy link
Contributor Author

cqliu1 commented Oct 5, 2020

If these components exist only for overview/landing pages, I would vote for exporting them directly from the kibana_overview plugin instead. This feels like the most logical domain for components that are for use in overview pages. (If you want to create your own overview page that looks similar to the global Kibana overview page, you'd expect to be able to find what you need in kibana_overview).

These components are used in the home plugin and the kibana_overview plugin, and I stuck them in kibana_react with the goal of having other solutions use these components on their overview/landing pages

@lukeelmers
Copy link
Member

lukeelmers commented Oct 5, 2020

I guess what I was suggesting is that the home plugin imports the components from kibana_overview so that they can live alongside other landing-page-related-stuff. I would assume kibana_overview is the first place folks would look when building their own app-specific overview page, so it makes sense that they'd find the components there.

I don't feel so strongly that it's worth holding up the PR, however I do think we should consider renaming the components if they stay in kibana_react.

Edit: The other minor benefit to putting the components in kibana_overview is that the Core UI team remains codeowners, which I think makes more sense anyway

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd highly suggest reviewing some of the generic namings of the page header and footer.

Also, consider running all the SVG's through an optimizer (SVGO).

defaultRoute === path ? (
<RedirectAppLinks application={application}>
<EuiButtonEmpty
className="pageFooter__button"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the pageFooter classes need the kbn prefix and ideally would be more specific even though the name of the component is simply PageFooter because it's so general it could conflict in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the prefixes to kbnOverviewPageFooter and kbnOverviewPageHeader

<RedirectAppLinks application={application}>
<EuiButtonEmpty
className="pageFooter__button"
flush="left"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned to @ryankeairns that the flush="both" prop is now available in Kibana if this can be rebased with master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I updated all of the buttons in the footer to flush="both"


return (
<header
className={`pageHeader ${overlap ? 'pageHeader--hasOverlap' : 'pageHeader--noOverlap'}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again all these classes ideally should be more specific and use the kbn prefix.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes LGTM
code review

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm comfortable with the naming updates to the kibana_react components, and I'll defer to @cchaos's comments on the finer details of the implementation.

If we find that these components end up being frequently updated or are expanded significantly, then perhaps we can revisit the discussion of where they should live. But since the usage isn't widespread ATM, I'm okay with this as a starting point.

@ryankeairns
Copy link
Contributor

ryankeairns commented Oct 6, 2020

@cqliu1 It looks like the basePath needs added to the links on the No data page as they currently resolve to a 'Not Found' page. This happens for the Add your data button and the footer links - Display a different page on log in and View app directory.

image

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes 👍

@ryankeairns
Copy link
Contributor

ryankeairns commented Oct 6, 2020

@cqliu1 That basePath issue is similarly affecting the header and footer links on the home page. Should we fix those here too?

If the answer is 'yes', then we could also stick a flush: both on the footer links while we're in the neighborhood. <-- already done :)

@ryankeairns
Copy link
Contributor

@cqliu1 That basePath issue is similarly affecting the header and footer links on the home page. Should we fix those here too?

If the answer is 'yes', then we could also stick a flush: both on the footer links while we're in the neighborhood. <-- already done :)

Disregard. Your recent commits fixed this since they were shared. 🙌

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
kibanaOverview - 32 +32
kibanaReact 293 307 +14
newsfeed 10 16 +6
total +52

async chunks size

id before after diff
advancedSettings 891.9KB 892.1KB +148.0B
home 413.6KB 404.2KB -9.4KB
kibanaOverview - 28.4KB +28.4KB
kibanaReact 358.4KB 358.4KB +21.0B
ml 10.6MB 10.6MB +172.0B
total +19.3KB

distributable file count

id before after diff
default 48094 48127 +33
oss 28993 29026 +33

page load bundle size

id before after diff
canvas 1.0MB 1.0MB +186.0B
dashboard 570.3KB 570.5KB +184.0B
discover 87.9KB 88.0KB +163.0B
enterpriseSearch 20.0KB 20.3KB +257.0B
graph 15.8KB 16.1KB +289.0B
home 26.7KB 26.0KB -711.0B
kibanaOverview - 40.3KB +40.3KB
kibanaReact 124.1KB 143.5KB +19.4KB
maps 164.5KB 164.7KB +174.0B
newsfeed 22.1KB 26.6KB +4.5KB
observability 71.2KB 71.4KB +243.0B
securitySolution 587.2KB 587.4KB +238.0B
urlForwarding 17.1KB 17.2KB +25.0B
total +65.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit 63b76f2 into master Oct 6, 2020
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Oct 6, 2020
* Added kibana landing page

Created kivana_overview plugin

Removed test from home plugin

Added CSS

Fixed page header links

Added news feed

Fixed spacers between news items

[Core UI] Kibana Overview Page Style Tweaks (elastic#76712)

Fixed link to index management

Added solution cards to kibana landing page

Added solution links

Fixed ts errors

Using publishReplay() to support multiple consumers in newsfeed plugin

Added createNewsFeed$ to newsfeed plugin start

Added tests

Removed unnecessary export

Hides overview link when other Kibana apps are not available

Added icon to overview plugin

Removed question mark from news feed title

Updated plugin-list

Fixed i18n errors

Revert snapshot

Updated getting started page copy

Hide news feed when no news feed results

Disables Kibana overview page when kibana apps are unavailable

Updated snapshots

Refactor to use KibanaContextProvider

Fixed security tests

Fixed newsfeed api test

Moved overview_footer and overview_header to kibana-react plugin

[Core UI] Kibana Overview Page Style Fixes (elastic#78677)

* Fixed a11y issues

* Made newsfeed optional dep of kibana overview plugin

* Removed duplicate license copy

* Fixed management security test

* Added toast to change default route button

* Updated snapshots

* Simplified toast notification

* Fixed i18n error

* Assigned kibana_overview plugin to Core UI in CODEOWNERS

* Updated snapshots

* Fix import

* [Core UI] Kibana Overview Page Style Fixes, Part 3 (elastic#78970)

* fix overview cards not stretching height equally

* change var name for better specificity

* [Core UI] Kibana Overview Page Style Fixes, Part 4 (elastic#79136)

* Adds support for all newsfeed plugin config settings in createNewsFeed$

* Fixed type

* Updated kibana overview page route

* Fixed imports in page_footer and page_header

* Update Kibana overview graphics (elastic#79534)

* Updated snapshots

* Updated snapshots

* Changes newsfeed endpoint to kibana analytics in kibana_overview plugin

* Renamed components

* Fixed overview page footer and header component class names

* Removed extraneous files

* Fixed import

* Replaced SVGs with optimized SVGs

* Fixed header and footer in home and kibana overview pages

* Updated snapshots

* Changed url_forwarding plugin appRoute

* Fixed aria-labelledby value

* Updated snapshots

* Added base paths

Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
# Conflicts:
#	.github/CODEOWNERS
cqliu1 added a commit that referenced this pull request Oct 6, 2020
* [Core UI] Kibana Overview Page (#75827)

* Added kibana landing page

Created kivana_overview plugin

Removed test from home plugin

Added CSS

Fixed page header links

Added news feed

Fixed spacers between news items

[Core UI] Kibana Overview Page Style Tweaks (#76712)

Fixed link to index management

Added solution cards to kibana landing page

Added solution links

Fixed ts errors

Using publishReplay() to support multiple consumers in newsfeed plugin

Added createNewsFeed$ to newsfeed plugin start

Added tests

Removed unnecessary export

Hides overview link when other Kibana apps are not available

Added icon to overview plugin

Removed question mark from news feed title

Updated plugin-list

Fixed i18n errors

Revert snapshot

Updated getting started page copy

Hide news feed when no news feed results

Disables Kibana overview page when kibana apps are unavailable

Updated snapshots

Refactor to use KibanaContextProvider

Fixed security tests

Fixed newsfeed api test

Moved overview_footer and overview_header to kibana-react plugin

[Core UI] Kibana Overview Page Style Fixes (#78677)

* Fixed a11y issues

* Made newsfeed optional dep of kibana overview plugin

* Removed duplicate license copy

* Fixed management security test

* Added toast to change default route button

* Updated snapshots

* Simplified toast notification

* Fixed i18n error

* Assigned kibana_overview plugin to Core UI in CODEOWNERS

* Updated snapshots

* Fix import

* [Core UI] Kibana Overview Page Style Fixes, Part 3 (#78970)

* fix overview cards not stretching height equally

* change var name for better specificity

* [Core UI] Kibana Overview Page Style Fixes, Part 4 (#79136)

* Adds support for all newsfeed plugin config settings in createNewsFeed$

* Fixed type

* Updated kibana overview page route

* Fixed imports in page_footer and page_header

* Update Kibana overview graphics (#79534)

* Updated snapshots

* Updated snapshots

* Changes newsfeed endpoint to kibana analytics in kibana_overview plugin

* Renamed components

* Fixed overview page footer and header component class names

* Removed extraneous files

* Fixed import

* Replaced SVGs with optimized SVGs

* Fixed header and footer in home and kibana overview pages

* Updated snapshots

* Changed url_forwarding plugin appRoute

* Fixed aria-labelledby value

* Updated snapshots

* Added base paths

Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
# Conflicts:
#	.github/CODEOWNERS

* Updated kibana_overview application order

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@spalger spalger deleted the kibana-overview branch May 8, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:enhancement review v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OSS text for Kibana card on the new home page [Onboarding] Kibana landing page