Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation to display an error when creating index action in alert with invalid document. #75929

Merged

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Aug 25, 2020

Added UI validation for index document:
img

I've double checked if it is possible to edit an invalid action document value and it is working in master (might be fixed in one of the SO PRs).
Resolve #74769

@YulNaumenko YulNaumenko added release_note:fix Feature:Alerting v8.0.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 labels Aug 25, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner August 25, 2020 21:17
@YulNaumenko YulNaumenko self-assigned this Aug 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote self-requested a review August 31, 2020 17:37
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works much better 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
triggers_actions_ui 736.9KB +322.0B 736.6KB

page load bundle size

id value diff baseline
triggers_actions_ui 264.1KB +553.0B 263.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alerting] error when creating index action in alert with invalid document
4 participants