[APM] Fix overlapping transaction names #76083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in the table and the header. Did this by adding `word-break: break-all` to them. Also: * Rename List to TransactionList * Add stories for TransactionList and ApmHeader * Add missing type information to transactions based on sample transaction * Fixes elastic#73960.
|
Pinging @elastic/apm-ui (Team:apm) |
|
retest |
|
@elasticmachine merge upstream |
sorenlouv
reviewed
Aug 28, 2020
sorenlouv
reviewed
Aug 28, 2020
| @@ -19,6 +19,7 @@ export type AgentName = | |||
| | 'ruby'; | |||
|
|
|||
| export interface Agent { | |||
| ephemeral_id?: string; | |||
There was a problem hiding this comment.
Until now we've only added fields we were actively using. Adding every field didn't add much value since most of them are never used by the ui, and was time consuming since it is a manual process.
There was a problem hiding this comment.
I'm actively using it in the Storybook. I'm ok with manually adding them, but it should be a reasonable assumption that I can copy real data from the UI, paste it into a story or test, and have it pass the type checker.
|
@elasticmachine merge upstream |
sorenlouv
approved these changes
Sep 4, 2020
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 7, 2020
* master: [APM] Use observer.hostname instead of observer.name (elastic#76074) Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751) Remove legacy deprecation adapter (elastic#76753) [Security Solution][Detections] Rule forms cleanup (elastic#76138) Adds back in custom images for reporting + tests (elastic#76810) [APM] Fix overlapping transaction names (elastic#76083) [Ingest Pipelines] Add descriptions for ingest processors A-D (elastic#75975)
smith
added a commit
to smith/kibana
that referenced
this pull request
Sep 8, 2020
...in the table and the header. Did this by adding `word-break: break-all` to them. Also: * Rename List to TransactionList * Add stories for TransactionList and ApmHeader * Add missing type information to transactions based on sample transaction Fixes elastic#73960. # Conflicts: # x-pack/plugins/apm/typings/es_schemas/raw/fields/host.ts # x-pack/plugins/apm/typings/es_schemas/raw/fields/service.ts
smith
added a commit
that referenced
this pull request
Sep 8, 2020
...in the table and the header. Did this by adding `word-break: break-all` to them. Also: * Rename List to TransactionList * Add stories for TransactionList and ApmHeader * Add missing type information to transactions based on sample transaction Fixes #73960. # Conflicts: # x-pack/plugins/apm/typings/es_schemas/raw/fields/host.ts # x-pack/plugins/apm/typings/es_schemas/raw/fields/service.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in the table and the header. Did this by adding
word-break: break-allto them.Before:
After:
Also:
Fixes #73960.