Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bl sub-dependency #76260

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Bump bl sub-dependency #76260

merged 1 commit into from
Aug 31, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Aug 31, 2020

This PR bumps the bl sub-dependency to the newest version.

I had to drop using decompress and switch to extract-zip because decompress depends on decompress-tar which depends on an old version of bl and unfortunately decompress-tar hasn't been updated in 3 years. We don't need the tar capabilities of decompress since we just need to decompress zip files, so extract-zip minimizes our dependency scope.

Regarding the tar-fs major upgrade: There doesn't seem to be any breaking changes besides tar-fs dropping support for older Node.js versions.

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.1 v6.8.13 labels Aug 31, 2020
@watson watson self-assigned this Aug 31, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

distributable file count

id value diff baseline
total 44390 +17 44373

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson marked this pull request as ready for review August 31, 2020 10:24
@watson watson requested a review from a team as a code owner August 31, 2020 10:24
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watson watson merged commit b21071e into elastic:master Aug 31, 2020
@watson watson deleted the bump-bl branch August 31, 2020 15:28
watson added a commit to watson/kibana that referenced this pull request Aug 31, 2020
watson added a commit to watson/kibana that referenced this pull request Sep 1, 2020
# Conflicts:
#	packages/kbn-es/package.json
#	packages/kbn-plugin-helpers/package.json
#	packages/kbn-plugin-helpers/src/integration_tests/build.test.ts
#	packages/kbn-test/package.json
#	yarn.lock
watson added a commit that referenced this pull request Sep 1, 2020
watson added a commit that referenced this pull request Sep 1, 2020
watson added a commit that referenced this pull request Sep 2, 2020
@LeeDr LeeDr added v7.9.2 and removed v7.9.1 labels Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v6.8.13 v7.9.2 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants