-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bl sub-dependency #76260
Merged
Merged
Bump bl sub-dependency #76260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
v7.9.1
v6.8.13
labels
Aug 31, 2020
mistic
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Aug 31, 2020
watson
added a commit
to watson/kibana
that referenced
this pull request
Aug 31, 2020
watson
added a commit
to watson/kibana
that referenced
this pull request
Sep 1, 2020
# Conflicts: # packages/kbn-es/package.json # packages/kbn-plugin-helpers/package.json # packages/kbn-plugin-helpers/src/integration_tests/build.test.ts # packages/kbn-test/package.json # yarn.lock
This was referenced Sep 1, 2020
watson
added a commit
that referenced
this pull request
Sep 1, 2020
watson
added a commit
that referenced
this pull request
Sep 1, 2020
watson
added a commit
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the
bl
sub-dependency to the newest version.I had to drop using
decompress
and switch toextract-zip
becausedecompress
depends ondecompress-tar
which depends on an old version ofbl
and unfortunatelydecompress-tar
hasn't been updated in 3 years. We don't need the tar capabilities ofdecompress
since we just need to decompress zip files, soextract-zip
minimizes our dependency scope.Regarding the
tar-fs
major upgrade: There doesn't seem to be any breaking changes besidestar-fs
dropping support for older Node.js versions.