Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Settings panel redesign and separate settings per y axis #76373

Merged
merged 39 commits into from
Sep 16, 2020
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
f051cb4
wip, redsign the xy axis general settings
stratoula Aug 31, 2020
24ff477
merge with master
stratoula Sep 1, 2020
3510ae3
pie chart settings. fix tests, initial implementation
stratoula Sep 1, 2020
d8369f4
Fix Internationalization
stratoula Sep 1, 2020
36fa43e
Cleanup
stratoula Sep 1, 2020
684897c
remove unused translations
stratoula Sep 1, 2020
f5e4676
Add test to check that right axis is enabled
stratoula Sep 2, 2020
5addfc8
fix test
stratoula Sep 2, 2020
1d82ea5
remove unecessary translation
stratoula Sep 2, 2020
87b9c74
Added icons and cleaned up some of the visuals for grouped buttons
Sep 4, 2020
7b0aadc
Merge branch 'master' into lens-settings-redesign
elasticmachine Sep 7, 2020
0733692
Fix types
stratoula Sep 7, 2020
c00859f
Axis Settings Popover Reusable Component
stratoula Sep 7, 2020
18f0928
Legend Popover Reusable Component
stratoula Sep 7, 2020
161da2a
Cleanup unused translations
stratoula Sep 7, 2020
88f30d5
Fix right axis behavior
stratoula Sep 8, 2020
e60353e
Revert yLeftTitle to yTitle to avoid migration
stratoula Sep 8, 2020
97f26d0
Merge branch 'master' into lens-settings-redesign
elasticmachine Sep 9, 2020
d00cd30
PR fixes
stratoula Sep 9, 2020
d6530b2
identify which axis is enabled
stratoula Sep 9, 2020
69cce9d
Change the logic on enabling the y axes popovers
stratoula Sep 10, 2020
193c3a5
Adjust axis popover on horizontal bars
stratoula Sep 10, 2020
a2ca47e
fix failing test and change the logic of fetching the y axis titles
stratoula Sep 10, 2020
4ac9300
Merge branch 'master' into lens-settings-redesign
elasticmachine Sep 10, 2020
69fb3b5
Simpify the axis title logic, make the toolbar repsponsive, add TopAx…
stratoula Sep 10, 2020
6d8012b
Ui Changes on legends popover
stratoula Sep 10, 2020
baf3e39
Merge branch 'master' into lens-settings-redesign
elasticmachine Sep 14, 2020
d864557
Cleanup and more unit tests
stratoula Sep 14, 2020
781b129
resolve conflicts
stratoula Sep 14, 2020
c599cb0
use groupId instead of index to take under consideration all possible…
stratoula Sep 14, 2020
9532136
fix gridlines
stratoula Sep 14, 2020
12aa5db
Remove ts-ignore from icons and move toolbar button to shared components
stratoula Sep 14, 2020
c02337f
Workspace toolbar wraps on smaller devices
stratoula Sep 15, 2020
5b0578a
resolve conficts
stratoula Sep 15, 2020
ae18fc3
Tooltip on Toolbar appears only if the button is disabled
stratoula Sep 15, 2020
942be29
clean up
stratoula Sep 15, 2020
3a053fa
Add missing translations
stratoula Sep 16, 2020
52159b0
fix eslint
stratoula Sep 16, 2020
c01443f
Merge branch 'master' into lens-settings-redesign
elasticmachine Sep 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions x-pack/plugins/lens/public/assets/axis_bottom.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

import * as React from 'react';

export const EuiIconAxisBottom = ({ title, titleId, ...props }) => (
<svg
width={16}
height={16}
viewBox="0 0 16 16"
fill="none"
xmlns="http://www.w3.org/2000/svg"
aria-labelledby={titleId}
{...props}
>
{title ? <title id={titleId}>{title}</title> : null}
<path d="M5 1.5a.5.5 0 111 0v7a.5.5 0 01-1 0v-7zM15.39 11.39a1.5 1.5 0 010 2.12l-2.122 2.122a.5.5 0 11-.707-.707l2.121-2.122a.5.5 0 000-.707l-2.121-2.12a.5.5 0 11.707-.708l2.121 2.121zM3.439 9.269a.5.5 0 010 .707l-2.122 2.121a.5.5 0 000 .707l2.122 2.121a.5.5 0 01-.707.708L.61 13.51a1.5 1.5 0 010-2.121l2.122-2.121a.5.5 0 01.707 0zM8 3a.5.5 0 01.5.5v5a.5.5 0 01-1 0v-5A.5.5 0 018 3zM11 5.5a.5.5 0 00-1 0v3a.5.5 0 001 0v-3z" />
<path d="M3.5 12a.5.5 0 000 1h9a.5.5 0 000-1h-9z" />
</svg>
);
24 changes: 24 additions & 0 deletions x-pack/plugins/lens/public/assets/axis_left.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

import * as React from 'react';

export const EuiIconAxisLeft = ({ title, titleId, ...props }) => (
<svg
width={16}
height={16}
viewBox="0 0 16 16"
fill="none"
xmlns="http://www.w3.org/2000/svg"
aria-labelledby={titleId}
{...props}
>
{title ? <title id={titleId}>{title}</title> : null}
<path d="M7.378 3.585a.5.5 0 00.353-.854L5.61.611a1.5 1.5 0 00-2.121 0L1.367 2.73a.5.5 0 00.708.707l2.12-2.12a.5.5 0 01.708 0l2.121 2.12a.5.5 0 00.354.147z" />
<path d="M5.046 3.088v4.129l.005.04v5.658a.5.5 0 01-.992.09l-.01-.09V8.786l-.004-.04V3.087a.5.5 0 01.992-.09l.01.09z" />
<path d="M4.55 15.829a1.5 1.5 0 001.06-.44l2.122-2.121a.5.5 0 10-.707-.707l-2.121 2.121a.5.5 0 01-.708 0l-2.12-2.121a.5.5 0 00-.708.707l2.121 2.121a1.5 1.5 0 001.061.44zM13.5 4a.5.5 0 01.5.5v7a.5.5 0 11-1 0v-7a.5.5 0 01.5-.5zM10.5 6.5a.5.5 0 011 0v5a.5.5 0 11-1 0v-5zM8.5 8a.5.5 0 00-.5.5v3a.5.5 0 101 0v-3a.5.5 0 00-.5-.5z" />
</svg>
);
24 changes: 24 additions & 0 deletions x-pack/plugins/lens/public/assets/axis_right.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

import * as React from 'react';

export const EuiIconAxisRight = ({ title, titleId, ...props }) => (
<svg
width={16}
height={16}
viewBox="0 0 16 16"
fill="none"
xmlns="http://www.w3.org/2000/svg"
aria-labelledby={titleId}
{...props}
>
{title ? <title id={titleId}>{title}</title> : null}
<path d="M8.622 3.585a.5.5 0 01-.353-.854L10.39.611a1.5 1.5 0 012.121 0l2.122 2.12a.5.5 0 11-.707.707l-2.122-2.12a.5.5 0 00-.707 0l-2.121 2.12a.5.5 0 01-.354.147z" />
<path d="M11.95 12.915V8.786l.005-.04V3.087a.5.5 0 00-.992-.09l-.01.09v4.129l-.004.04v5.658a.5.5 0 00.992.09l.01-.09z" />
<path d="M11.45 15.829a1.5 1.5 0 01-1.06-.44l-2.122-2.121a.5.5 0 11.707-.707l2.121 2.121a.5.5 0 00.707 0l2.122-2.121a.5.5 0 01.707.707l-2.121 2.121a1.5 1.5 0 01-1.061.44zM2.5 4a.5.5 0 00-.5.5v7a.5.5 0 101 0v-7a.5.5 0 00-.5-.5zM5.5 6.5a.5.5 0 00-1 0v5a.5.5 0 101 0v-5zM7.5 8a.5.5 0 01.5.5v3a.5.5 0 11-1 0v-3a.5.5 0 01.5-.5z" />
</svg>
);
39 changes: 39 additions & 0 deletions x-pack/plugins/lens/public/assets/legend.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

import * as React from 'react';

export const EuiIconLegend = ({ title, titleId, ...props }: { title: string; titleId: string }) => (
<svg
width={16}
height={16}
viewBox="0 0 16 16"
fill="none"
xmlns="http://www.w3.org/2000/svg"
aria-labelledby={titleId}
{...props}
>
{title ? <title id={titleId}>{title}</title> : null}
<path
clipRule="evenodd"
fillRule="evenodd"
d="M2.786.357a.25.25 0 01.428 0l2.559 4.264A.25.25 0 015.558 5H.442a.25.25 0 01-.215-.379L2.786.357zM3 1.944L4.234 4H1.766L3 1.944z"
/>
<path d="M8.5 2a.5.5 0 000 1h7a.5.5 0 000-1h-7z" />
<path
clipRule="evenodd"
fillRule="evenodd"
d="M1.5 6a.5.5 0 00-.5.5v3a.5.5 0 00.5.5h3a.5.5 0 00.5-.5v-3a.5.5 0 00-.5-.5h-3zM2 7v2h2V7H2z"
/>
<path d="M8.5 7.5a.5.5 0 000 1h7a.5.5 0 000-1h-7z" />
<path
clipRule="evenodd"
fillRule="evenodd"
d="M3 16a2.5 2.5 0 100-5 2.5 2.5 0 000 5zm0-1a1.5 1.5 0 100-3 1.5 1.5 0 000 3z"
/>
<path d="M8.5 13a.5.5 0 000 1h7a.5.5 0 000-1h-7z" />
</svg>
);
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export function WorkspacePanelWrapper({
return (
<>
<div className="lnsWorkspacePanelWrapper__toolbar">
<EuiFlexGroup gutterSize="s" direction="row" responsive={false}>
<EuiFlexGroup gutterSize="m" direction="row" responsive={false}>
<EuiFlexItem grow={false}>
<ChartSwitch
data-test-subj="lnsChartSwitcher"
Expand All @@ -82,7 +82,7 @@ export function WorkspacePanelWrapper({
/>
</EuiFlexItem>
{activeVisualization && activeVisualization.renderToolbar && (
<EuiFlexItem grow>
<EuiFlexItem grow={false}>
<NativeRenderer
render={activeVisualization.renderToolbar}
nativeProps={{
Expand Down
Loading