Convert map client routing files to TS #76387

shamin · 2020-09-01T14:57:17Z

Summary

This PR convert map client routing files to TS fixes [Maps] Convert client routing files to TS #69448. I have added types for what I could find. This covers most but you can see some any. I can update those with some help from the team.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

kibanamachine · 2020-09-01T14:57:19Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

nreese · 2020-09-01T15:33:28Z

retest

elasticmachine · 2020-09-01T15:34:19Z

Pinging @elastic/kibana-gis (Team:Geo)

x-pack/plugins/maps/public/connected_components/map_container/map_container.tsx

shamin · 2020-09-01T18:20:08Z

I have fixed the type check errors and eslint errors shown by the Jenkins.

nreese

Thank you for submitting this PR. It great to see these files converted to TS.

x-pack/plugins/maps/public/routing/bootstrap/get_initial_query.ts

x-pack/plugins/maps/public/routing/bootstrap/get_initial_refresh_config.ts

x-pack/plugins/maps/public/routing/bootstrap/get_initial_time_filters.ts

x-pack/plugins/maps/public/routing/routes/maps_app/index.ts

x-pack/plugins/maps/public/routing/routes/maps_app/load_map_and_render.tsx

x-pack/plugins/maps/public/routing/maps_router.tsx

x-pack/plugins/maps/public/routing/routes/maps_app/maps_app_view.tsx

shamin · 2020-09-02T16:24:23Z

@nreese I have made the changes you suggested. Also fixed some merge conflicts.

nreese

Thanks for the clean-up. This is looking really great. Just some more suggestions to get read of any and some other typings clean-up

x-pack/plugins/maps/public/routing/routes/maps_app/load_map_and_render.tsx

x-pack/plugins/maps/public/routing/routes/maps_app/maps_app_view.tsx

x-pack/plugins/maps/public/routing/state_syncing/app_state_manager.ts

shamin · 2020-09-03T18:00:06Z

@nreese Made the changes you suggested.

nreese · 2020-09-03T18:18:58Z

retest

nreese

Thanks for all of the changes. Renaming savedQuery to savedQueryId in AppState really helps clarify things.

Mind syncing with master to fix merge conflicts?

git fetch upstream
git pull upstream master
git push origin {branch_name}

x-pack/plugins/maps/public/routing/routes/maps_app/load_map_and_render.tsx

x-pack/plugins/maps/public/routing/routes/maps_app/maps_app_view.tsx

x-pack/plugins/maps/public/routing/state_syncing/app_state_manager.ts

x-pack/plugins/maps/public/routing/state_syncing/global_sync.ts

x-pack/plugins/maps/public/routing/routes/list/maps_list_view.tsx

…typescript

nreese · 2020-09-08T12:28:55Z

@elasticmachine merge upstream

lizozom

Code owner change is TS export LGTM

nreese

Thanks for all of the updates. Just a few more comments

x-pack/plugins/maps/public/routing/state_syncing/app_state_manager.ts

x-pack/plugins/maps/public/routing/bootstrap/get_initial_query.ts

src/plugins/navigation/public/top_nav_menu/top_nav_menu.tsx

shamin · 2020-09-08T15:49:35Z

@nreese Made the changes you suggested.

nreese · 2020-09-08T15:54:56Z

retest

nreese · 2020-09-08T16:16:41Z

@shamin Looks like CI is failing because some autogenerated API documentation needs to be updated.

See below commands from https://github.com/elastic/kibana/pull/76387/checks?check_run_id=1086876819 to update the documentation and commit the changes.

nreese

Just a few more details

x-pack/plugins/maps/public/routing/routes/maps_app/load_map_and_render.tsx

x-pack/plugins/maps/public/routing/routes/list/maps_list_view.tsx

x-pack/plugins/maps/public/routing/routes/maps_app/maps_app_view.tsx

shamin · 2020-09-08T19:36:22Z

@nreese Made the changes you suggested. Also updated the autogenerated docs.

nreese · 2020-09-08T19:43:38Z

retest

kibanamachine · 2020-09-08T21:30:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5e31e4c

Build metrics

async chunks size

id	value	diff	baseline
maps	3.3MB	+451.0B	3.3MB

page load bundle size

id	value	diff	baseline
data	1.4MB	+206.0B	1.4MB

History

💔 Build #73161 failed 33fa7b3
💔 Build #72387 failed 9d13b6f
💔 Build #71601 failed 4ada8b5bf46e101f459125079846771b4a3ac7fc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese

Thanks for contributing to Kibana. These are great changes that are really bringing the typings together.

LGTM
code review

* Converted maps_router and store operations files * Converted files in map routes to typescript * Removed an unwanted ts-expect-error * Fixed the lint errors from jenkins * Naming changes, type for mapStateJSON etc. * More type fixes in map routes * More type fixes in map routes * Added back some removed props * Added types to app state manager * Autogenerated api documentation * Type fixes Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

nreese · 2020-09-08T22:04:25Z

backport 7.x #76991

* Converted maps_router and store operations files * Converted files in map routes to typescript * Removed an unwanted ts-expect-error * Fixed the lint errors from jenkins * Naming changes, type for mapStateJSON etc. * More type fixes in map routes * More type fixes in map routes * Added back some removed props * Added types to app state manager * Autogenerated api documentation * Type fixes Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Shamin Meerankutty <8272719+shamin@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

shamin requested a review from a team as a code owner September 1, 2020 14:57

kibanamachine added the 💝community label Sep 1, 2020

nreese added release_note:skip Skip the PR/issue when compiling release notes [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.10.0 v8.0.0 labels Sep 1, 2020

nreese reviewed Sep 1, 2020

View reviewed changes

x-pack/plugins/maps/public/connected_components/map_container/map_container.tsx Outdated Show resolved Hide resolved

shamin requested a review from a team as a code owner September 1, 2020 18:18

nreese reviewed Sep 2, 2020

View reviewed changes

shamin added 5 commits September 2, 2020 21:33

Converted maps_router and store operations files

f1ecc97

Converted files in map routes to typescript

dd42cff

Removed an unwanted ts-expect-error

7ef4d89

Fixed the lint errors from jenkins

f06a0d1

Naming changes, type for mapStateJSON etc.

765f772

shamin force-pushed the maps/routing-typescript branch from 8680384 to 765f772 Compare September 2, 2020 16:16

nreese reviewed Sep 2, 2020

View reviewed changes

More type fixes in map routes

9d13b6f

nreese reviewed Sep 3, 2020

View reviewed changes

shamin added 2 commits September 4, 2020 21:47

More type fixes in map routes

46f0980

Merge branch 'master' of github.com:elastic/kibana into maps/routing-…

d763c67

…typescript

Merge branch 'master' into maps/routing-typescript

f9bf639

lizozom approved these changes Sep 8, 2020

View reviewed changes

Added back some removed props

6836aec

nreese reviewed Sep 8, 2020

View reviewed changes

Added types to app state manager

33fa7b3

nreese reviewed Sep 8, 2020

View reviewed changes

shamin added 2 commits September 9, 2020 00:55

Autogenerated api documentation

c027668

Type fixes

5e31e4c

nreese approved these changes Sep 8, 2020

View reviewed changes

nreese merged commit 194d0b0 into elastic:master Sep 8, 2020

nreese mentioned this pull request Sep 8, 2020

[7.x] Convert map client routing files to TS (#76387) #76991

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert map client routing files to TS #76387

Convert map client routing files to TS #76387

shamin commented Sep 1, 2020

kibanamachine commented Sep 1, 2020

nreese commented Sep 1, 2020

elasticmachine commented Sep 1, 2020

shamin commented Sep 1, 2020

nreese left a comment

shamin commented Sep 2, 2020

nreese left a comment

shamin commented Sep 3, 2020

nreese commented Sep 3, 2020

nreese left a comment

nreese commented Sep 8, 2020

lizozom left a comment

nreese left a comment

shamin commented Sep 8, 2020

nreese commented Sep 8, 2020

nreese commented Sep 8, 2020

nreese left a comment

shamin commented Sep 8, 2020

nreese commented Sep 8, 2020

kibanamachine commented Sep 8, 2020

nreese left a comment

nreese commented Sep 8, 2020

Convert map client routing files to TS #76387

Convert map client routing files to TS #76387

Conversation

shamin commented Sep 1, 2020

Summary

Checklist

For maintainers

kibanamachine commented Sep 1, 2020

nreese commented Sep 1, 2020

elasticmachine commented Sep 1, 2020

shamin commented Sep 1, 2020

nreese left a comment

Choose a reason for hiding this comment

shamin commented Sep 2, 2020

nreese left a comment

Choose a reason for hiding this comment

shamin commented Sep 3, 2020

nreese commented Sep 3, 2020

nreese left a comment

Choose a reason for hiding this comment

nreese commented Sep 8, 2020

lizozom left a comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

shamin commented Sep 8, 2020

nreese commented Sep 8, 2020

nreese commented Sep 8, 2020

nreese left a comment

Choose a reason for hiding this comment

shamin commented Sep 8, 2020

nreese commented Sep 8, 2020

kibanamachine commented Sep 8, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

nreese left a comment

Choose a reason for hiding this comment

nreese commented Sep 8, 2020