Move streams utils to the core #76397

mshustov · 2020-09-01T15:46:41Z

Summary

Move steams from the legacy platform under src/core/server/utils folder
TS-ify streams code

mshustov · 2020-09-02T10:37:25Z

packages/kbn-es-archiver/src/lib/streams.ts

+  createSplitStream,
+  createMapStream,
+  createReplaceStream,
+} from '../../../../src/legacy/utils';


Packages cannot have deps on core, it breaks incapsulation and TS build. @spalger what is the best approach to remove the dependency? We might move streams out of the core. Maybe in an existing or a dedicated package. I thought kbn-dev-utils is a good candidate, but turned out it's not: For running integration tests in Kibana.

I have every intention of removing the reliance on node streams in the es archiver, but not today. For now I'll just decouple the package from the src directory by copying the stream source into the package.

So for now I keep it as is. Do you agree?

elasticmachine · 2020-09-02T15:11:51Z

Pinging @elastic/kibana-platform (Team:Platform)

jportner

Code review only -- Spaces changes to x-pack/plugins/spaces/server/routes/api/__fixtures__/create_copy_to_space_mocks.ts LGTM 👍

spalger

LGTM, removed shared streaming utils with es-archiver

…ls-steams

kibanamachine · 2020-09-03T08:55:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0262b1d

Build metrics

✅ unchanged

History

💚 Build #72056 succeeded 016b299
💚 Build #71843 succeeded 425523b
💔 Build #71805 failed 918850d
💔 Build #71802 failed 18a7d13
💔 Build #71605 failed 1c8c429

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* move utils/streams to the KP * allow imports from src/core/server/utils * ts-ify * import streams from KP * remove unnecessary ts-expect-error * fix kbn-es-archiver build * lost export * copy array in createListStream * remove streams from legacy utils Co-authored-by: spalger <spalger@users.noreply.github.com>

* move utils/streams to the KP * allow imports from src/core/server/utils * ts-ify * import streams from KP * remove unnecessary ts-expect-error * fix kbn-es-archiver build * lost export * copy array in createListStream * remove streams from legacy utils Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com>

…nes/processors-forms-k-s * 'master' of github.com:elastic/kibana: (216 commits) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) Replace FetchOptions with ISearchOptions (elastic#76538) Move streams utils to the core (elastic#76397) [Ingest Manager] Wording & linking improvements (elastic#76284) remove legacy kibana plugin (elastic#76064) [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379) Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482) [APM] Service maps layout enhancements (elastic#76481) [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586) [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544) Index Pattern class - remove toJSON and toString (elastic#76246) skip failing suite (elastic#76581) Split up and clarify Enterprise Search codeowners (elastic#76580) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processor_settings_fields.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx

…oleysens/kibana into ingest-pipelines/processors-forms-k-s * 'ingest-pipelines/processors-forms-k-s' of github.com:jloleysens/kibana: (216 commits) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) Replace FetchOptions with ISearchOptions (elastic#76538) Move streams utils to the core (elastic#76397) [Ingest Manager] Wording & linking improvements (elastic#76284) remove legacy kibana plugin (elastic#76064) [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379) Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482) [APM] Service maps layout enhancements (elastic#76481) [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586) [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544) Index Pattern class - remove toJSON and toString (elastic#76246) skip failing suite (elastic#76581) Split up and clarify Enterprise Search codeowners (elastic#76580) ...

mshustov added 2 commits September 1, 2020 17:40

move utils/streams to the KP

a306e7c

allow imports from src/core/server/utils

1c8c429

mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 1, 2020

mshustov added 6 commits September 2, 2020 10:22

ts-ify

5d8a7e1

import streams from KP

1bff16b

remove unnecessary ts-expect-error

18a7d13

Merge branch 'master' into core-utils-steams

918850d

fix kbn-es-archiver build

2d49050

lost export

c667c48

mshustov commented Sep 2, 2020

View reviewed changes

copy array in createListStream

425523b

mshustov mentioned this pull request Sep 2, 2020

Switch to typescript project references and incremental builds #46773

Closed

7 tasks

mshustov marked this pull request as ready for review September 2, 2020 15:11

mshustov requested review from a team as code owners September 2, 2020 15:11

jportner approved these changes Sep 2, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into pr/76397

016b299

spalger approved these changes Sep 2, 2020

View reviewed changes

mshustov added 3 commits September 3, 2020 07:58

Merge branch 'master' into core-utils-steams

05d7079

Merge remote-tracking branch 'origin/core-utils-steams' into core-uti…

5b1e841

…ls-steams

remove streams from legacy utils

0262b1d

pgayvallet approved these changes Sep 3, 2020

View reviewed changes

patrykkopycinski approved these changes Sep 3, 2020

View reviewed changes

mshustov merged commit cd86b81 into elastic:master Sep 3, 2020

mshustov deleted the core-utils-steams branch September 3, 2020 08:57

mshustov mentioned this pull request Sep 3, 2020

[7.x] Move streams utils to the core (#76397) #76609

Merged

mshustov added the backported label Sep 3, 2020

This was referenced Sep 6, 2020

Move utils/streams out of legacy #54128

Closed

Move core config service to kbn/config package #76874

Merged

pgayvallet mentioned this pull request Sep 8, 2020

Create the @kbn/std package #76925

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move streams utils to the core #76397

Move streams utils to the core #76397

mshustov commented Sep 1, 2020 •

edited

Loading

mshustov Sep 2, 2020

spalger Sep 2, 2020

mshustov Sep 2, 2020

spalger Sep 2, 2020

elasticmachine commented Sep 2, 2020

jportner left a comment

spalger left a comment

kibanamachine commented Sep 3, 2020

Move streams utils to the core #76397

Move streams utils to the core #76397

Conversation

mshustov commented Sep 1, 2020 • edited Loading

Summary

mshustov Sep 2, 2020

Choose a reason for hiding this comment

spalger Sep 2, 2020

Choose a reason for hiding this comment

mshustov Sep 2, 2020

Choose a reason for hiding this comment

spalger Sep 2, 2020

Choose a reason for hiding this comment

elasticmachine commented Sep 2, 2020

jportner left a comment

Choose a reason for hiding this comment

spalger left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 3, 2020

💚 Build Succeeded

Build metrics

History

mshustov commented Sep 1, 2020 •

edited

Loading