Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es-archiver: Drop invalid index settings, support --query flag #76522

Merged
merged 3 commits into from
Sep 3, 2020

Conversation

dgieselaar
Copy link
Member

Drops the following settings, as some of them are not allowed or create issues when creating indices:

  • index.frozen
  • index.search.throttled
  • index.query
  • index.routing

Additionally, implements a --query flag, that parses the JSON it is given, and passes it to the search operation of the save action. This allows users of es-archiver to limit the documents that should be stored in the snapshot, e.g. a time range.

@dgieselaar dgieselaar requested a review from a team as a code owner September 2, 2020 15:25
@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 2, 2020
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works well, but one requested change.

packages/kbn-es-archiver/src/cli.ts Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 53c7414 into elastic:master Sep 3, 2020
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Sep 4, 2020
…ic#76522)

* ESArchiver: Drop invalid index settings, support --query flag for saving archive

* Describe query flag
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2020
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (75 commits)
  Remove legacy ui-apps-mixin (elastic#76604)
  remove unused test_utils (elastic#76528)
  [ML] Functional tests - add UI permission tests (elastic#76368)
  [APM] @ts-error -> @ts-expect-error (elastic#76492)
  [APM] Avoid negative offset for error marker on timeline (elastic#76638)
  [Reporting] rename interfaces to align with task manager integration (elastic#76716)
  Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start (elastic#76220)
  Test reverting "Add plugin status API (elastic#75819)" (elastic#76707)
  [Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (elastic#76595)
  [Maps] remove region/coordinate-maps visualizations from sample data (elastic#76399)
  [DOCS] Dashboard-first docs refresh (elastic#76194)
  Updated ServiceNow description in docs and actions management UI to contains correct info (elastic#76344)
  [DOCS] Identifies cloud settings in reporting (elastic#76691)
  [Security Solution] Refactor timeline details to use search strategy (elastic#75591)
  es-archiver: Drop invalid index settings, support --query flag  (elastic#76522)
  [DOCS] Identifies graph settings available on cloud (elastic#76661)
  Add more info about a11y tests (elastic#76045)
  [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943)
  [release notes] automatically retry on Github API 5xx errors (elastic#76447)
  [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392)
  ...
dgieselaar added a commit that referenced this pull request Sep 4, 2020
* ESArchiver: Drop invalid index settings, support --query flag for saving archive

* Describe query flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants