-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LP deprecations #76536
Remove LP deprecations #76536
Conversation
packages/kbn-test/src/functional_test_runner/lib/config/read_config_file.ts
Outdated
Show resolved
Hide resolved
Pinging @elastic/kibana-platform (Team:Platform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// transform deprecated plugin settings | ||
for (let i = 0; i < pluginSpecs.length; i++) { | ||
const spec = pluginSpecs[i]; | ||
const transform = await getTransform(spec); | ||
const prefix = spec.getConfigPrefix(); | ||
|
||
// nested plugin prefixes (a.b) translate to nested objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So glad this finally goes away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR changes LGTM
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/async_scripted_fields·js.discover async search with scripted fields query return results with valid scripted fieldStandard Out
Stack Trace
Build metricsoss distributable file count
distributable file count
History
To update your PR or re-run it, just comment with: |
* inline deprecations in kbn-test * remove LP deprecations * remove test * inline log call * remove unnecessary deprecations for the test config
Summary
The remaining legacy plugins do not deprecation mechanism, therefore we can remove it as a part of the legacy platform cleanup.