log request body in new ES client #77150

mshustov · 2020-09-10T10:47:58Z

Summary

Legacy client format:

server    log   [10:07:07.655] [debug][data][elasticsearch][query] 200
POST /.reporting-*/_search
{"seq_no_primary_term":true,"_source":{"excludes":["output.content"]},"query":{"bool":{"filter":{"bool":{"minimum_should_match":1,"should":[{"term":{"status":"pending"}},{"bool":{"must":[{"term":{"status":"processing"}},{"range":{"process_expiration":{"lte":"2020-09-10T08:07:07.652Z"}}}]}}]}}}},"sort":[{"priority":{"order":"asc"}},{"created_at":{"order":"asc"}}],"size":1}

New client format:

server    log   [10:07:07.413] [debug][data][elasticsearch][query] 200
POST /.kibana/_search?size=20&from=0&rest_total_hits_as_int=true
{"seq_no_primary_term":true,"query":{"bool":{"filter":[{"bool":{"should":[{"bool":{"must":[{"term":{"type":"upgrade-assistant-reindex-operation"}}],"must_not":[{"exists":{"field":"namespace"}},{"exists":{"field":"namespaces"}}]}}],"minimum_should_match":1}}],"must":[{"simple_query_string":{"query":"0","fields":["upgrade-assistant-reindex-operation.status"],"default_operator":"OR"}}]}}}

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-09-10T12:24:00Z

Pinging @elastic/kibana-platform (Team:Platform)

joshdover · 2020-09-14T23:08:44Z

src/core/server/elasticsearch/client/configure_client.test.ts

-        }),
-        { logger, scoped: false }
-      );
+    describe('logs each queries if `logQueries` is true', () => {


Can we add test cases for when body is null or undefined?

Added a test with undefined

kibanamachine · 2020-09-16T07:36:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2ab07b2

Build metrics

✅ unchanged

History

💔 Build #74384 failed 5a03e4d
💚 Build #74010 succeeded aa8833c
💚 Build #73643 succeeded 463efb9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* log request body in new ES client * add test case when body is null * update test

…s-for-710 * 'master' of github.com:elastic/kibana: (95 commits) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) [@kbn/utils] Adds missing dependency (elastic#77536) Add the Enterprise Search logo to the Overview search result (elastic#77514) [Logs UI] [Metrics UI] Remove saved object field mappings (elastic#75482) [Security Solution][Exceptions] Exception modal bulk close option only closes alerts generated by same rule (elastic#77402) Adds @kbn/utils package (elastic#76518) Map layout changes (elastic#77132) [Security Solution] [Detections] EQL Rule Creation (elastic#76831) Adding test user to maps tests under documents source folder (elastic#77245) Suppress error logs when clients connect over HTTP instead of HTTPS (elastic#77397) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx

* master: (55 commits) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) ...

* master: (54 commits) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058) ...

* master: (76 commits) Fixing service maps API test (elastic#77586) [Grok] Fix missing error message in error toasts (elastic#77499) [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563) [ML] fix type in apply_influencer_filters_action (elastic#77495) [Lens] create reusable component for filters and range aggregation (elastic#77453) fix eslint violations Collapse alert chart previews by default (elastic#77479) [ML] Fixing field caps wrapper endpoint (elastic#77546) showing service maps when filte by environment not defined (elastic#77483) [Lens] Settings panel redesign and separate settings per y axis (elastic#76373) log request body in new ES client (elastic#77150) use `navigateToUrl` to navigate to recent nav links (elastic#77446) Move core config service to `kbn/config` package (elastic#76874) [UBI] Copy license to /licenses folder (elastic#77563) Skip flaky Events Viewer Cypress test [Lens] Remove dynamic names in telemetry fields (elastic#76988) [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366) [Enterprise Search] Add flag to restrict width of layout (elastic#77539) [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967) [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090) ...

* log request body in new ES client * add test case when body is null * update test

log request body in new ES client

463efb9

mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 10, 2020

mshustov marked this pull request as ready for review September 10, 2020 12:23

mshustov requested a review from a team as a code owner September 10, 2020 12:23

Merge branch 'master' into issue-76463

aa8833c

joshdover approved these changes Sep 14, 2020

View reviewed changes

mshustov added 3 commits September 15, 2020 10:18

Merge branch 'master' into issue-76463

98c4f40

add test case when body is null

5a03e4d

update test

2ab07b2

mshustov merged commit 274d5de into elastic:master Sep 16, 2020

mshustov deleted the issue-76463 branch September 16, 2020 07:48

mshustov mentioned this pull request Sep 16, 2020

[7.x] log request body in new ES client (#77150) #77578

Merged

mshustov added a commit to mshustov/kibana that referenced this pull request Sep 16, 2020

log request body in new ES client (elastic#77150)

3769dd5

* log request body in new ES client * add test case when body is null * update test

mshustov added a commit that referenced this pull request Sep 16, 2020

log request body in new ES client (#77150) (#77578)

7719130

* log request body in new ES client * add test case when body is null * update test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

log request body in new ES client #77150

log request body in new ES client #77150

mshustov commented Sep 10, 2020 •

edited

Loading

elasticmachine commented Sep 10, 2020

joshdover Sep 14, 2020

mshustov Sep 16, 2020

kibanamachine commented Sep 16, 2020

log request body in new ES client #77150

log request body in new ES client #77150

Conversation

mshustov commented Sep 10, 2020 • edited Loading

Summary

elasticmachine commented Sep 10, 2020

joshdover Sep 14, 2020

Choose a reason for hiding this comment

mshustov Sep 16, 2020

Choose a reason for hiding this comment

kibanamachine commented Sep 16, 2020

💚 Build Succeeded

Build metrics

History

mshustov commented Sep 10, 2020 •

edited

Loading