Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OBS] Remove beta badge, change news feed size and add external icon to news feed link #77164

Merged
merged 4 commits into from
Sep 14, 2020
Merged

[OBS] Remove beta badge, change news feed size and add external icon to news feed link #77164

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb24eab
removing beta badge
cauemarcondes Sep 10, 2020
aa3a717
change news feed size and adding external icon
cauemarcondes Sep 10, 2020
15275b3
fixing i18n
cauemarcondes Sep 10, 2020
c28881d
Merge branch 'master' into obs-remove-beta
elasticmachine Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions x-pack/plugins/observability/public/components/app/header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

import {
EuiBetaBadge,
EuiButtonEmpty,
EuiFlexGroup,
EuiFlexItem,
Expand Down Expand Up @@ -58,12 +57,7 @@ export function Header({
<h1>
{i18n.translate('xpack.observability.home.title', {
defaultMessage: 'Observability',
})}{' '}
<EuiBetaBadge
className="eui-alignMiddle"
label={i18n.translate('xpack.observability.beta', { defaultMessage: 'Beta' })}
tooltipContent="This feature is in beta. Please help us improve it by reporting any bugs or give us feedback."
/>
})}
</h1>
</EuiTitle>
</EuiFlexItem>
Expand Down
8 changes: 4 additions & 4 deletions x-pack/plugins/observability/public/components/app/news_feed/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ function NewsItem({ item }: { item: INewsItem }) {
</EuiText>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiLink href={item.link_url.en} target="_blank">
<EuiText size="xs">
<EuiText size="xs">
<EuiLink href={item.link_url.en} target="_blank" external>
{i18n.translate('xpack.observability.news.readFullStory', {
defaultMessage: 'Read full story',
})}
</EuiText>
</EuiLink>
</EuiLink>
</EuiText>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/observability/public/pages/overview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ export function OverviewPage({ routeParams }: Props) {

{!!newsFeed?.items?.length && (
<EuiFlexItem grow={false}>
<NewsFeed items={newsFeed.items.slice(0, 3)} />
<NewsFeed items={newsFeed.items.slice(0, 5)} />
</EuiFlexItem>
)}
</EuiFlexGroup>
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13719,7 +13719,6 @@
"xpack.monitoring.updateLicenseTitle": "ライセンスの更新",
"xpack.monitoring.useAvailableLicenseDescription": "既に新しいライセンスがある場合は、今すぐアップロードしてください。",
"xpack.monitoring.wedLabel": "水",
"xpack.observability.beta": "ベータ",
"xpack.observability.emptySection.apps.alert.description": "503エラーが累積していますか?サービスは応答していますか?CPUとRAMの使用量が跳ね上がっていますか?このような警告を、事後にではなく、発生と同時に把握しましょう。",
"xpack.observability.emptySection.apps.alert.link": "アラートの作成",
"xpack.observability.emptySection.apps.alert.title": "アラートが見つかりません。",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13728,7 +13728,6 @@
"xpack.monitoring.updateLicenseTitle": "更新您的许可证",
"xpack.monitoring.useAvailableLicenseDescription": "如果已有新的许可证，请立即上传。",
"xpack.monitoring.wedLabel": "周三",
"xpack.observability.beta": "公测版",
"xpack.observability.emptySection.apps.alert.description": "503 错误是否越来越多？服务是否响应？CPU 和 RAM 利用率是否激增？实时查看警告，而不是事后再进行剖析。",
"xpack.observability.emptySection.apps.alert.link": "创建告警",
"xpack.observability.emptySection.apps.alert.title": "未找到告警。",
Expand Down