[ML] Transforms: Extend editing and creation options. #77370

walterra · 2020-09-14T16:23:18Z

Summary

Fixes #67304, part of #67255.

Extends the available options in the edit transform flyout and the wizard details step.

Edit Flyout

Organizes the form to have basic form fields and expandable advanced sections.

Wizard Details Step

Adds an advanced expandable section.

Review note:

The edit form and wizard form use different types of approaches to manage form state. That's why for now some code (e.g. validators) is duplicated. The edit form uses the more up to date approach, the transform wizard was one of the first UIs we built out using React hooks and is a bit dated (it gets more fiddly as we add more stuff whereas the approach used for the edit form should allow use to grow the code base in a more structure way). I plan to consolidate some of the code and make use of the newer approach in the wizard in follow ups.
The structure of where form elements are in the expandable sections of the edit form and the wizard are not 100% in line, for example frequency is on the outer level for the edit form and in the advanced section of the wizard. Feedback on the structure is very welcome.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-09-14T16:24:02Z

Pinging @elastic/ml-ui (:ml)

...ections/transform_management/components/edit_transform_flyout/edit_transform_flyout_form.tsx

x-pack/plugins/transform/public/app/common/validators.ts

...transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx

...ections/transform_management/components/edit_transform_flyout/edit_transform_flyout_form.tsx

peteharverson · 2020-09-15T14:10:56Z

...transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx

+              )}
+            >
+              <EuiFieldText
+                placeholder="max_page_search_size"


Can this be made the same placeholder text as in the edit form which is much more user-friendly.

If you delete the value in the wizard you get:

Updated the placeholder in 01d852b. I will look into fixing the NaN issue in a follow up when consolidating the form code. Added a note to the meta issue here: #77604

...transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx

pheyos

Thanks for adding a functional for the new feature! Just one suggestion.

x-pack/test/functional/services/transform/edit_flyout.ts

walterra · 2020-09-16T15:59:16Z

@peteharverson @pheyos pushed updates to your comments and PR is ready for another look 🤞

peteharverson · 2020-09-16T17:14:41Z

...transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx

 }

 const defaultContinuousModeDelay = '60s';
+const defaultTransformFrequency = '1m';


These settings don't seem to be copied over when cloning a job but reset to the defaults. Also even though it isn't exposed in the Create wizard, I think we should also copy over any docs_per_second setting.

Good catch, added this to the issue about fixing other missing attributes when cloning transforms: #75264

pheyos

Functional tests LGTM

peteharverson

Latest edits LGTM

qn895 · 2020-09-17T14:19:02Z

.../sections/transform_management/components/edit_transform_flyout/use_edit_transform_flyout.ts

+
+  const configValue = getNestedProperty(config, formStateAttribute.configFieldName, fallbackValue);
+
+  // only get depending values if we're not already in a call to get dependeing values.


nit: should be depending

qn895 · 2020-09-17T14:22:08Z

LGTM 💯

walterra · 2020-09-21T12:59:51Z

@elasticmachine merge upstream

kibanamachine · 2020-09-21T14:34:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 605d172

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
transform	503	+43	460

async chunks size

id	value	diff	baseline
transform	661.1KB	-107.5KB	768.6KB

History

💚 Build #75236 succeeded 399758f
💚 Build #75104 succeeded 719d6ad
💚 Build #74851 succeeded 280fa12
💚 Build #74843 succeeded 01d852b
💚 Build #74517 succeeded b62b649

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Extends the available options in the edit transform flyout and the wizard details step.

walterra added 7 commits September 14, 2020 16:47

[ML] Adds destination index to transform edit form.

ac4213b

[ML] Fix validation of required field.

7ce0986

[ML] Fix form validation.

9bab191

[ML] Tweak lodash imports.

56453c3

[ML] Adds settings.max_page_search_size to transform edit form.

4bf4036

[ML] Update functional tests to consider accordions.

43c3f60

[ML] Adds advanced settings section to transform wizard details step.

8b78c01

walterra requested a review from a team as a code owner September 14, 2020 16:23

walterra self-assigned this Sep 14, 2020

walterra added :ml Feature:Transforms ML transforms release_note:enhancement v7.10.0 v8.0.0 labels Sep 14, 2020

walterra requested review from peteharverson, qn895 and darnautov September 15, 2020 08:18

[ML] Fix translations.

286d12f

peteharverson reviewed Sep 15, 2020

View reviewed changes

...ections/transform_management/components/edit_transform_flyout/edit_transform_flyout_form.tsx Outdated Show resolved Hide resolved

peteharverson reviewed Sep 15, 2020

View reviewed changes

x-pack/plugins/transform/public/app/common/validators.ts Outdated Show resolved Hide resolved

peteharverson reviewed Sep 15, 2020

View reviewed changes

...transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx Outdated Show resolved Hide resolved

walterra added 6 commits September 15, 2020 16:55

[ML] Fix tests.

b62b649

[ML] Fix frequency validator.

7edc1bd

[ML] Tweak text.

38d0cdb

[ML] Tweak error message for max_page_search_size.

31f85f5

[ML] Improve integer validation.

0892877

[ML] Fix nullable form field validation.

3380cbf

walterra mentioned this pull request Sep 16, 2020

[ML] Transforms: Consolidate edit/create form code #77604

Open

7 tasks

pheyos reviewed Sep 16, 2020

View reviewed changes

x-pack/test/functional/services/transform/edit_flyout.ts Show resolved Hide resolved

walterra added 4 commits September 16, 2020 17:28

[ML] Improve documentation of state management.

6410f32

[ML] More user friendly placeholders.

01d852b

[ML] Tweak function name.

ae54ba5

Merge branch 'master' into ml-transforms-edit-3

280fa12

walterra requested review from pheyos and peteharverson September 16, 2020 15:58

peteharverson reviewed Sep 16, 2020

View reviewed changes

walterra mentioned this pull request Sep 17, 2020

[ML] Transforms: Cloning transform should retain description #75264

Closed

[ML] Add dot to sentence.

719d6ad

pheyos approved these changes Sep 17, 2020

View reviewed changes

peteharverson approved these changes Sep 17, 2020

View reviewed changes

qn895 reviewed Sep 17, 2020

View reviewed changes

qn895 approved these changes Sep 17, 2020

View reviewed changes

[ML] Fix typo.

399758f

Merge branch 'master' into ml-transforms-edit-3

605d172

walterra merged commit 4e7b7bf into elastic:master Sep 21, 2020

walterra deleted the ml-transforms-edit-3 branch September 21, 2020 14:55

walterra mentioned this pull request Sep 21, 2020

[7.x] [ML] Transforms: Extend editing and creation options. (#77370) #78023

Merged

walterra added a commit to walterra/kibana that referenced this pull request Sep 21, 2020

[ML] Transforms: Extend editing and creation options. (elastic#77370)

e4038d7

Extends the available options in the edit transform flyout and the wizard details step.

walterra added a commit that referenced this pull request Sep 21, 2020

[ML] Transforms: Extend editing and creation options. (#77370) (#78023)

f4b88bb

Extends the available options in the edit transform flyout and the wizard details step.

walterra mentioned this pull request Sep 23, 2020

[ML] Transforms: Edit transforms flyout #67255

Open

12 tasks

peteharverson mentioned this pull request Oct 8, 2020

[ML] Transform: UI support for writing to a pipeline instead of an index #50045

Open

hendrikmuhs mentioned this pull request Nov 25, 2020

[ML][Transform] Transform UI writes defaults into the config #84351

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Transforms: Extend editing and creation options. #77370

[ML] Transforms: Extend editing and creation options. #77370

walterra commented Sep 14, 2020 •

edited

Loading

elasticmachine commented Sep 14, 2020

peteharverson Sep 15, 2020

walterra Sep 16, 2020

pheyos left a comment

walterra commented Sep 16, 2020

peteharverson Sep 16, 2020

walterra Sep 17, 2020

pheyos left a comment

peteharverson left a comment

qn895 Sep 17, 2020 •

edited

Loading

qn895 commented Sep 17, 2020

walterra commented Sep 21, 2020

kibanamachine commented Sep 21, 2020


		const configValue = getNestedProperty(config, formStateAttribute.configFieldName, fallbackValue);

		// only get depending values if we're not already in a call to get dependeing values.

[ML] Transforms: Extend editing and creation options. #77370

[ML] Transforms: Extend editing and creation options. #77370

Conversation

walterra commented Sep 14, 2020 • edited Loading

Summary

Edit Flyout

Wizard Details Step

Checklist

For maintainers

elasticmachine commented Sep 14, 2020

peteharverson Sep 15, 2020

Choose a reason for hiding this comment

walterra Sep 16, 2020

Choose a reason for hiding this comment

pheyos left a comment

Choose a reason for hiding this comment

walterra commented Sep 16, 2020

peteharverson Sep 16, 2020

Choose a reason for hiding this comment

walterra Sep 17, 2020

Choose a reason for hiding this comment

pheyos left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

qn895 Sep 17, 2020 • edited Loading

Choose a reason for hiding this comment

qn895 commented Sep 17, 2020

walterra commented Sep 21, 2020

kibanamachine commented Sep 21, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

History

walterra commented Sep 14, 2020 •

edited

Loading

qn895 Sep 17, 2020 •

edited

Loading