Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Move core config service to kbn/config package (#76874) #77575

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

pgayvallet
Copy link
Contributor

Backports the following commits to 7.x:

* move deprecations and raw loader to package

* move config service to package

* start to adapt the usages

* adapt yet more usages

* update generated doc

* move logging types to `@kbn/logging`

* update generated doc

* add yarn.lock symlink

* merge @kbn-logging PR

* adapt Env.createDefault

* update generated doc

* remove mock exports from the main entrypoint to avoid importing it in production code

* use dynamic require to import `REPO_ROOT` from bootstrap file

* move logger mock to kbn-logging package

* address review comments

* import PublicMethodOf from kbn/utility-types

* fix import conflict

* update generated doc

* use the @kbn/std package

* update generated doc

* adapt plugin service mock
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
core 562 -1 563

async chunks size

id value diff baseline
enterpriseSearch 429.7KB +45.0B 429.7KB

page load bundle size

id value diff baseline
core 1.2MB -51.0B 1.2MB
upgradeAssistant 64.4KB +45.0B 64.3KB
total -6.0B

distributable file count

id value diff baseline
default 47628 +301 47327
oss 29418 +468 28950
total +769

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 9984c06 into elastic:7.x Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants