Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Refactor Hosts Kpi to use Search Strategy #77606

Merged
merged 14 commits into from
Sep 22, 2020
Merged

[Security Solution] Refactor Hosts Kpi to use Search Strategy #77606

merged 14 commits into from
Sep 22, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Sep 16, 2020 •
edited
Loading

Summary

image

Checklist

@patrykkopycinski patrykkopycinski self-assigned this Sep 16, 2020
@patrykkopycinski patrykkopycinski marked this pull request as ready for review September 18, 2020 14:56
@patrykkopycinski patrykkopycinski requested review from a team as code owners September 18, 2020 14:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

angorayc
angorayc reviewed Sep 21, 2020
View reviewed changes
x-pack/plugins/security_solution/public/hosts/components/kpi_hosts/index.test.tsx
* you may not use this file except in compliance with the Elastic License.
*/

import { mockKpiHostsData, mockKpiHostDetailsData } from './mock';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing this test, mock.tsx is not in used, can be removed as well.

angorayc
angorayc reviewed Sep 21, 2020
View reviewed changes
x-pack/plugins/security_solution/public/hosts/components/authentications_table/translations.ts Outdated
@@ -7,7 +7,7 @@
import { i18n } from '@kbn/i18n';

export const AUTHENTICATIONS = i18n.translate(
'xpack.securitySolution.authenticationsTable.authenticationFailures',
'xpack.securitySolution.authenticationsTable.authenticationsFailures',
Copy link
Contributor

@angorayc angorayc Sep 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this to xpack.securitySolution.authenticationsTable.authentications instead, as its default message is authentications.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 2017 +11 2006

async chunks size

id value diff baseline
securitySolution 10.2MB +70.3KB 10.1MB

distributable file count

id value diff baseline
default 45941 +14 45927

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit c03c7b3 into elastic:master Sep 22, 2020
@patrykkopycinski patrykkopycinski deleted the feat/hosts-kpi-search-strategy branch September 22, 2020 10:45
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 22, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 22, 2020
@patrykkopycinski
[Security Solution] Refactor Hosts Kpi to use Search Strategy (elasti…
85499d8 
…c#77606)
patrykkopycinski added a commit that referenced this pull request Sep 22, 2020
@patrykkopycinski
[Security Solution] Refactor Hosts Kpi to use Search Strategy (#77606) (
e7e9aba 
#78137)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 22, 2020
@gmmorris
Merge branch 'master' into actions/pagerduty-dedup
56e81d2 
* master: (45 commits)
  [CSM] Use stacked chart for page views (elastic#78042)
  [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091)
  Remove service map beta badge (elastic#78039)
  [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124)
  [Alerting] optimize calculation of unmuted alert instances (elastic#78021)
  call .destroy on ace when react component unmounts (elastic#78132)
  [Ingest Manager] Fix agent action acknowledgement (elastic#78089)
  [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127)
  [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606)
  Bump backport to 5.6.0 (elastic#78097)
  [Actions] adds a Test Connector tab in the Connectors list (elastic#77365)
  [Uptime] Improve ping chart axis (elastic#77992)
  [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363)
  [UiActions] Remove duplicate apply filter action  (elastic#77485)
  [APM] Use transaction metrics for transaction error rate (elastic#78009)
  [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983)
  Edit UI text strings in Integrations and Fleet tabs (elastic#75837)
  [baseline capture] switch to large workers (elastic#78109)
  [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956)
  [Mappings editor] Add support for point field type (elastic#77543)
  ...
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 24, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @angorayc @MindyRS