77133 check if transform exist before stopping and deleting

[nnamdifrankie]

Summary

• check for transform in ES before stopping or deleting.

Checklist

Delete any items that are not applicable to this PR.features that require explanation or tutorials

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/ingest-management (Team:Ingest Management)

[jfsiii]

Approval so you can ship if you need to.

I left some notes, but since time is a factor and they're not difficult to change later, I'm fine with shipping this as-is if you want.

I have not checked this out and run locally yet. I'm doing that now.

[jfsiii]

Our current pattern is to have functions use the logger like const logger = appContextService.getLogger(); vs adding them to every function signature.

e.g.

kibana/x-pack/plugins/ingest_manager/server/services/epm/elasticsearch/ingest_pipeline/remove.ts

Line 19 in 46a268f

const logger = appContextService.getLogger();

[jfsiii]

@nnamdifrankie are the changes from 52a972c alone enough to prevent the 400's we saw?

Not a big deal, but I'm curious about the effect the bad(?) paths have now

[jfsiii]

I just checked this out locally and ran it against two different Cloud ES hosts that were failing. Both /setup calls returned {"isInitialized":true} 🎉

[nnamdifrankie]

@jfsiii

Not a big deal, but I'm curious about the effect the bad(?) paths have now

There is no negative effect. I test both locally, integration test and against the cloud. It only make a difference I believe for remote host from what I can see. Where it is required because a fullpath may be given.

[jfsiii]

@nnamdifrankie it's more than "no negative effect" it's the fix. At least in my tests.

It's also consistent with the path format in the other elasticsearch/*/install.ts files

👍 to ship as soon as you're comfortable. I can deal with the logging & try/catch later

Thanks again!

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 9741974

Build metrics

✅ unchanged

History

• 💔 Build #75005 failed 52a972c
• 💔 Build #74878 failed aeade44

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream