-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaning up esaggs #77646
cleaning up esaggs #77646
Conversation
Pinging @elastic/kibana-app-arch (Team:AppArch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
// We only need to reexecute the query, if forceFetch was true or the hash of the request body has changed | ||
// since the last request | ||
const shouldQuery = forceFetch || (searchSource as any).lastQuery !== queryHash; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be removing the forceFetch
request handler param as well, since it doesn't do anything at this point?
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally in chrome. Ran through some sanity checks in visualize and lens to make sure everything still works as expected.
Everything LGTM
Summary
esaggs was using
calculateObjectHash
method tosince introducing expressions, this was no longer functioning as expected as searchsource on which the hashes were stored is recreated on every execution.
in the expression world this should be solved by expression caching mechanism and should not require doing things like this.
this PR removes this functionality, which was not working and was causing significant performance hit.