[Lens] Navigate from discover to lens #77873

stratoula · 2020-09-18T11:32:04Z

Summary

As we want to promote Lens, this PR changes the navigation from Discover (Visualize button) to Lens instead of the legacy visualizations. On OSS nothing changes, this applies only for Basic+ licenses.

To accomplish this, Lens must unregister the Visualize action and register its own. It adds the indexPatternId and the fieldName to the location state and passes it to the Lens architecture in order to depict the suggestions to the users.

Note: We decided to not have a link for Lens right now, for this reason the right click on Visualize button doesn't work anymore.

Example of bytes field (kibana_sample_data_logs dataset) visualization to Lens:

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

stratoula · 2020-09-23T07:16:26Z

@elasticmachine merge upstream

…discover

elasticmachine · 2020-09-24T13:35:27Z

Pinging @elastic/kibana-app (Team:KibanaApp)

wylieconlon

Thanks for taking a look at this! I would mainly like you to make this more generic, with the perspective that we want to add other ways of navigating to Lens from apps, not just discover.

wylieconlon · 2020-09-24T21:27:30Z

src/plugins/ui_actions/public/types.ts

 export type ActionType = keyof ActionContextMapping;

 export interface ActionContextMapping {
  [DEFAULT_ACTION]: BaseContext;
  [ACTION_VISUALIZE_FIELD]: VisualizeFieldContext;
  [ACTION_VISUALIZE_GEO_FIELD]: VisualizeFieldContext;
+  [ACTION_VISUALIZE_LENS_FIELD]: VisualizeFieldContext;


So if I understand this correctly, this is using the same trigger, but different action for Lens- this sounds like what we agreed.

Yes, exactly same trigger VISUALIZE_FIELD_TRIGGER but different action!

x-pack/plugins/lens/kibana.json

x-pack/plugins/lens/public/app_plugin/app.tsx

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx

x-pack/plugins/lens/public/indexpattern_datasource/indexpattern_suggestions.test.tsx

x-pack/plugins/lens/public/indexpattern_datasource/indexpattern_suggestions.ts

x-pack/plugins/lens/public/trigger_actions/visualize_field_actions.ts

stratoula · 2020-09-28T06:01:45Z

@elasticmachine merge upstream

Dosant

Didn't test, uiActions usage lgtm

x-pack/plugins/lens/public/trigger_actions/visualize_field_actions.ts

x-pack/plugins/lens/public/plugin.ts

src/plugins/ui_actions/public/types.ts

stratoula · 2020-09-29T09:24:40Z

@elasticmachine merge upstream

flash1293

Great work so far @stratoula ! I added some comments, but it feels really close already.

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx

stratoula · 2020-09-30T09:41:50Z

@elasticmachine merge upstream

…alize field

stratoula · 2020-10-01T06:27:31Z

@elasticmachine merge upstream

stratoula · 2020-10-02T06:31:32Z

@elasticmachine merge upstream

…ula/kibana into navogate-discover-to-lens

flash1293

Almost perfect from my side, left a small comment

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx

flash1293

Thanks, Lens changes LGTM once build is green

stratoula · 2020-10-05T05:59:30Z

@elasticmachine merge upstream

kibanamachine · 2020-10-05T07:29:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d5e6b68

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`lens`	563	564	+1

async chunks size

id	before	after	diff
`lens`	1.1MB	1.1MB	+3.6KB

page load bundle size

id	before	after	diff
`lens`	76.0KB	78.7KB	+2.7KB
`uiActions`	80.6KB	80.8KB	+184.0B
`visualize`	41.4KB	41.4KB	+47.0B
total			+2.9KB

History

💚 Build #79116 succeeded a27df91
💚 Build #79065 succeeded 35b8297
💛 Build #79049 was flaky 92d512b
💚 Build #78608 succeeded 5e62b42
💔 Build #78602 failed bd09d21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

wylieconlon

Reviewed and tested again, LGTM!

wylieconlon · 2020-10-05T20:17:11Z

x-pack/plugins/lens/public/app_plugin/mounter.tsx

@@ -132,6 +134,11 @@ export async function mountApp(
        onAppLeave={params.onAppLeave}
        setHeaderActionMenu={params.setHeaderActionMenu}
        history={routeProps.history}
+        initialContext={
+          historyLocationState && historyLocationState.type === ACTION_VISUALIZE_LENS_FIELD
+            ? historyLocationState.payload


This is okay, but I was almost expecting the entire historyLocationState to be passed in here so that the app is making fewer decisions. No need to change it unless you're planning on making other changes.

* Create lens action and unregister the visualize one * remove console * Implement Discover to Lens, wip, missing tests * Add unit tests * fix embed lens to empty dashboard functional tests * fix suggestions on save * Fix bug on save button, query and filters should be transferred from discover * Add functional test for the navigation from Discover to Lens * PR update after code review * unregister visualize action only if the action exists * Change the test to not be flaky * Move suggestions to editor frame and hide the emptyWorkspace for visualize field * Update ui actions docs * Add a retry to remove test flakiness * Fix bug of infinite loader when removing the y axis dimension Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.actioncontextmapping.md # docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.md # docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.addtriggeraction.md # docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.getaction.md # docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.gettriggeractions.md # docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.gettriggercompatibleactions.md # docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.md # docs/development/plugins/ui_actions/public/kibana-plugin-plugins-ui_actions-public.uiactionsservice.registeraction.md # src/plugins/ui_actions/public/public.api.md

stratoula added 4 commits September 18, 2020 14:20

Create lens action and unregister the visualize one

f2c3e56

remove console

278e51b

Implement Discover to Lens, wip, missing tests

a8a7591

Add unit tests

c018989

elasticmachine and others added 6 commits September 23, 2020 03:16

Merge branch 'master' into navogate-discover-to-lens

39992f5

fix embed lens to empty dashboard functional tests

80e56ae

fix suggestions on save

03b5cb9

Fix bug on save button, query and filters should be transferred from …

601361b

…discover

resolve conflicts

bf30921

Add functional test for the navigation from Discover to Lens

b50e628

stratoula added Feature:Lens v7.11.0 v8.0.0 enhancement New value added to drive a business result release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 24, 2020

stratoula marked this pull request as ready for review September 24, 2020 13:35

stratoula requested a review from a team September 24, 2020 13:35

stratoula requested a review from a team as a code owner September 24, 2020 13:35

stratoula requested a review from flash1293 September 24, 2020 13:35

wylieconlon suggested changes Sep 24, 2020

View reviewed changes

stratoula added 2 commits September 28, 2020 09:05

Merge branch 'master' into navogate-discover-to-lens

0f48077

PR update after code review

1519f93

Dosant approved these changes Sep 29, 2020

View reviewed changes

x-pack/plugins/lens/public/trigger_actions/visualize_field_actions.ts Show resolved Hide resolved

x-pack/plugins/lens/public/plugin.ts Outdated Show resolved Hide resolved

src/plugins/ui_actions/public/types.ts Show resolved Hide resolved

elasticmachine and others added 2 commits September 29, 2020 05:24

Merge branch 'master' into navogate-discover-to-lens

ff28aee

unregister visualize action only if the action exists

89c8662

Change the test to not be flaky

caaed27

flash1293 reviewed Sep 30, 2020

View reviewed changes

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx Outdated Show resolved Hide resolved

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx Outdated Show resolved Hide resolved

elasticmachine and others added 3 commits September 30, 2020 05:41

Merge branch 'master' into navogate-discover-to-lens

2f949fe

Move suggestions to editor frame and hide the emptyWorkspace for visu…

83da4fa

…alize field

resolve conflicts and merge with master

eedc7bb

elasticmachine and others added 2 commits October 1, 2020 02:27

Merge branch 'master' into navogate-discover-to-lens

bd09d21

Update ui actions docs

5e62b42

elasticmachine and others added 3 commits October 2, 2020 02:31

Merge branch 'master' into navogate-discover-to-lens

92d512b

Add a retry to remove test flakiness

32dd2bd

Merge branch 'navogate-discover-to-lens' of https://github.com/strato…

35b8297

…ula/kibana into navogate-discover-to-lens

flash1293 reviewed Oct 2, 2020

View reviewed changes

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx Show resolved Hide resolved

Fix bug of infinite loader when removing the y axis dimension

a27df91

flash1293 approved these changes Oct 2, 2020

View reviewed changes

Merge branch 'master' into navogate-discover-to-lens

d5e6b68

stratoula requested a review from wylieconlon October 5, 2020 06:14

wylieconlon approved these changes Oct 5, 2020

View reviewed changes

stratoula added v7.10.0 and removed v7.11.0 labels Oct 6, 2020

stratoula merged commit 08a4586 into elastic:master Oct 6, 2020

stratoula mentioned this pull request Oct 6, 2020

[7.x] [Lens] Navigate from discover to lens (#77873) #79626

Merged

wylieconlon mentioned this pull request Nov 11, 2020

[Lens] Deep Link into a prefilled editor #59845

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Navigate from discover to lens #77873

[Lens] Navigate from discover to lens #77873

stratoula commented Sep 18, 2020 •

edited

Loading

stratoula commented Sep 23, 2020

elasticmachine commented Sep 24, 2020

wylieconlon left a comment

wylieconlon Sep 24, 2020

stratoula Sep 28, 2020

stratoula commented Sep 28, 2020

Dosant left a comment

stratoula commented Sep 29, 2020

flash1293 left a comment

stratoula commented Sep 30, 2020

stratoula commented Oct 1, 2020

stratoula commented Oct 2, 2020

flash1293 left a comment

flash1293 left a comment

stratoula commented Oct 5, 2020

kibanamachine commented Oct 5, 2020

wylieconlon left a comment

wylieconlon Oct 5, 2020

[Lens] Navigate from discover to lens #77873

[Lens] Navigate from discover to lens #77873

Conversation

stratoula commented Sep 18, 2020 • edited Loading

Summary

Checklist

stratoula commented Sep 23, 2020

elasticmachine commented Sep 24, 2020

wylieconlon left a comment

Choose a reason for hiding this comment

wylieconlon Sep 24, 2020

Choose a reason for hiding this comment

stratoula Sep 28, 2020

Choose a reason for hiding this comment

stratoula commented Sep 28, 2020

Dosant left a comment

Choose a reason for hiding this comment

stratoula commented Sep 29, 2020

flash1293 left a comment

Choose a reason for hiding this comment

stratoula commented Sep 30, 2020

stratoula commented Oct 1, 2020

stratoula commented Oct 2, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

stratoula commented Oct 5, 2020

kibanamachine commented Oct 5, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

wylieconlon left a comment

Choose a reason for hiding this comment

wylieconlon Oct 5, 2020

Choose a reason for hiding this comment

stratoula commented Sep 18, 2020 •

edited

Loading