Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Usage Collection] [Schema] "kibana" collector #77893

Merged
merged 4 commits into from
Sep 24, 2020
Merged

[Usage Collection] [Schema] "kibana" collector #77893

merged 4 commits into from
Sep 24, 2020

Conversation

afharo
Copy link
Member

@afharo afharo commented Sep 18, 2020 •
edited
Loading

Summary

Add schema definition to the collector kibana.

Related to #70180

For maintainers

@afharo afharo added Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 18, 2020
@afharo afharo requested a review from a team as a code owner September 18, 2020 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo afharo mentioned this pull request Sep 18, 2020
Closed
14 tasks
@afharo
Copy link
Member Author

afharo commented Sep 21, 2020

@elasticmachine merge upstream

@afharo
Copy link
Member Author

afharo commented Sep 23, 2020

@elasticmachine merge upstream

@afharo
Copy link
Member Author

afharo commented Sep 23, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/plugins/kibana_usage_collection/server/collectors/kibana/kibana_usage_collector.ts
type: 'kibana',
isReady: () => true,
schema: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The payload for stack_stats.kibana doesn't contain an index field, it has indices as a long. I assume we're adding os, versions and plugins through a different collector.

@afharo afharo merged commit 9ca2238 into elastic:master Sep 24, 2020
@afharo afharo deleted the usage_collection/schema/kibana_usage_collection branch September 24, 2020 09:51
afharo added a commit to afharo/kibana that referenced this pull request Sep 24, 2020
@afharo @elasticmachine
[Usage Collection] [Schema] "kibana" collector (elastic#77893)
62365a8 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@afharo afharo mentioned this pull request Sep 24, 2020
Merged
afharo added a commit that referenced this pull request Sep 24, 2020
@afharo @elasticmachine
[7.x] [Usage Collection] [Schema] "kibana" collector (#77893) (#78397)
2ff1156 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afharo @elasticmachine @kibanamachine @TinaHeiligers @lukeelmers