Removing the code plugin entirely for 8.0 #77940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
v8.0.0
release_note:skip
|
retest |
|
@elasticmachine merge upstream |
joshdover
approved these changes
Oct 5, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@wayneseymour removing the code plugin is breaking . I'm struggling to figure out what's going on here, any hints? |
|
@wayneseymour, NVM! I believe this will be fixed by fba1ece |
tylersmalley
approved these changes
Oct 22, 2020
wayneseymour
reviewed
Feb 9, 2021
| [ | ||
| 'src/dev/code_coverage/ingest_coverage/integration_tests/fixtures/test_plugin/server/index.ts kibana-tre', | ||
| 'src/dev/code_coverage/ingest_coverage/integration_tests/fixtures/test_plugin/server/plugin.ts kibana-tre', | ||
| ].join(os.EOL) |
There was a problem hiding this comment.
whoa, I've been in the js world for years and years, never saw os.EOL. Pretty kewl :)
wayneseymour
approved these changes
Feb 9, 2021
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@kibanamachine don't be rude... |
kobelb
force-pushed
the
remove-code-8.0
branch
from
55eee26 to
8af0404
Compare
|
looking into this |
|
@kobelb Ok I fixedup the test, it passes on my local: |
|
Thanks @wayneseymour! |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 11, 2021
* master: (44 commits) [APM] Add experimental support for Data Streams (elastic#89650) [Search Session] Control "Kibana / Search Sessions" management section by privileges (elastic#90818) [Lens] Median as default function (elastic#90952) Implement custom global header banner (elastic#87438) [Fleet] Reduce permissions. (elastic#90302) Update dependency @elastic/charts to v24.5.1 (elastic#89822) [Create index pattern] Can't create single character index without wildcard (elastic#90919) [ts/build_ts_refs] add support for --clean flag (elastic#91060) Don't clean when running e2e tests (elastic#91057) Fixes track_total_hits in the body not having an effect when using search strategy (elastic#91068) [Security Solution][Detections] Adds list plugin Saved Objects to Security feature privilege (elastic#90895) Removing the code plugin entirely for 8.0 (elastic#77940) chore(NA): move the instruction to remove yarn global bazelisk package into the first place on install bazel tools (elastic#91026) [jest/ci] remove max-old-space-size override to use 4gb default (elastic#91020) [Fleet] Restrict integration changes for managed policies (elastic#90675) [CI] Fix auto-backport condditions so that it doesn't trigger for other labels (elastic#91042) [DOCS] Uses variable to refer to query profiler (elastic#90976) [App Search] Relevance Tuning logic listeners (elastic#89461) [Metrics UI] Fix saving/loading saved views from URL (elastic#90216) Limit cardinality of transaction.name (elastic#90955) ...
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A majority of the code plugin was removed as part of #49404, but we left behind the parts necessary to not break users who specified
xpack.code.*settings in theirkibana.yml. The aforementioned PR has been backported, but we no longer need any of the code plugin code inmaster. This PR removes all of the remaining code plugin in preparation for 8.0.