[Security Solution][Resolver] Update @timestamp formatting #78166

michaelolo24 · 2020-09-22T15:59:06Z

Summary

Updates the timestamp fields in the panel to use the dateFormat defined in the advanced settings. See below for the default format:

Node List:

Node Detail:

Events Of Type:

Event Detail:

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-09-22T18:48:00Z

Pinging @elastic/endpoint-app-team (Feature:Resolver)

elasticmachine · 2020-09-22T18:48:02Z

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

oatkiller · 2020-09-22T19:00:26Z

x-pack/plugins/security_solution/public/resolver/view/panels/use_format_date.ts

+import { useUiSetting } from '../../../../../../../src/plugins/kibana_react/public';
+import { formatter, invalidDateText } from './panel_content_utilities';
+
+export function useDateFormatSetting(


This hook returns a formatted date so maybe this name could be useFormattedDate.

lol, just renamed it. Saw I missed a few spots. Was confused why the ticket only named the event-detail, but it's all timestamps in the panel. Anyways will be updated shortly

oatkiller · 2020-09-22T19:00:50Z

x-pack/plugins/security_solution/public/resolver/view/panels/use_format_date.ts

+
+import moment from 'moment-timezone';
+import { useUiSetting } from '../../../../../../../src/plugins/kibana_react/public';
+import { formatter, invalidDateText } from './panel_content_utilities';


You could just inline these values here, they probably shouldn't need to be in 'panel_content_utilities'

Yea, just did that. Will be up shortly

bkimmel · 2020-09-22T19:22:25Z

x-pack/plugins/security_solution/public/resolver/view/panels/panel_content_utilities.tsx

@@ -122,7 +122,7 @@ export const formatter = new Intl.DateTimeFormat(i18n.getLocale(), {
  second: '2-digit',
 });

-const invalidDateText = i18n.translate(
+export const invalidDateText = i18n.translate(


❔ doc comment needed

I don't think we should export string literals like this. Let's just move it to where it is being used.

No exporting anymore, but will add

bkimmel · 2020-09-22T19:24:41Z

x-pack/plugins/security_solution/public/resolver/view/panels/use_format_date.ts

+  if (timestamp === undefined) return null;
+
+  const date = new Date(timestamp);
+  if (date && isFinite(date.getTime())) {


❔ Should this be Number.isFinite instead of the global one?

Yea, thanks

That wasn't a passive-aggressive "I think that should be Number.isFinite" btw, I seriously don't know. It might depend on if you want to allow nulls or something.

Oh lol, I didn't take it as passive aggressive 😂, it just should be since we cast it to a date beforehand so getTime() should return a number if it's a valid date. Just realized I didn't update this either. Will update the PR

oatkiller · 2020-09-22T20:02:19Z

@michaelolo24 Could you try fixing this now? https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/resolver/test_utilities/simulator/index.tsx#L300

michaelolo24 · 2020-09-22T20:02:21Z

x-pack/plugins/security_solution/public/resolver/view/panels/use_formatted_date.ts

+  const dateFormatSetting: string = useUiSetting('dateFormat');
+  const timezoneSetting: string = useUiSetting('dateFormat:tz');
+
+  if (timestamp === undefined) return invalidDateText;


Do we want to list the lack of a timestamp as an invalidDate or just leave it blank and return and empty string? There were some places where we did that, just wasn't sure if that would be confusing to the user. Maybe text here instead saying Missing Time Details or similar?

ya, we could use the missing badge that we use somewhere else.

Where can one find said badge?

kqualters-elastic

lgtm

bkimmel · 2020-09-22T21:15:15Z

x-pack/plugins/security_solution/public/resolver/view/panels/use_formatted_date.ts

+/**
+ *
+ * @description formats a given time based on the user defined format in the advanced settings section of kibana under dateFormat
+ * @export


ℹ️ oooh fancy

oatkiller

nice

michaelolo24 · 2020-09-24T20:30:10Z

@elasticmachine merge upstream

michaelolo24 · 2020-09-25T04:42:15Z

@elasticmachine merge upstream

michaelolo24 · 2020-09-25T04:43:55Z

@elasticmachine merge upstream

kibanamachine · 2020-09-25T06:16:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 24cf3c8

Metrics [docs]

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	1968	+1	1967

async chunks size

id	value	diff	baseline
securitySolution	10.2MB	+2.0KB	10.2MB

History

💔 Build #77122 failed ac56895
💔 Build #77069 failed a5f336a
💔 Build #76990 failed 35bd5d9fa16e602ef84a86637cc9206641cbd8a4
💔 Build #76974 failed 303d53721b914e5dd25ec6b4cc390c3d16f26b45
💔 Build #76955 failed ecb361e14f1e8ce6fecfd6915dcbc291fb836faf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…8166) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

@timestamp

* master: (226 commits) [Enterprise Search] Added Logic for the Credentials View (elastic#77626) [CSM] Js errors (elastic#77919) Add the @kbn/apm-config-loader package (elastic#77855) [Security Solution] Refactor useSelector (elastic#75297) Implement tagcloud renderer (elastic#77910) [APM] Alerting: Add global option to create all alert types (elastic#78151) [Ingest pipelines] Upload indexed document to test a pipeline (elastic#77939) TypeScript cleanup in visualizations plugin (elastic#78428) Lazy load metric & mardown visualizations (elastic#78391) [Detections][EQL] EQL rule execution in detection engine (elastic#77419) Update tutorial-full-experience.asciidoc (elastic#75836) Update tutorial-define-index.asciidoc (elastic#75754) Add support for runtime field types to mappings editor. (elastic#77420) [Monitoring] Usage collection (elastic#75878) [Docs][Actions] Add docs for Jira and IBM Resilient (elastic#78316) [Security Solution][Resolver] Update @timestamp formatting (elastic#78166) [Security Solution] Fix app layout (elastic#76668) [Security Solution][Resolver] 2 new functions to DAL (elastic#78477) Adds new elasticsearch client to telemetry plugin (elastic#78046) skip flaky suite (elastic#78512) (elastic#78511) (elastic#78510) (elastic#78509) (elastic#78508) (elastic#78507) (elastic#78506) (elastic#78505) (elastic#78504) (elastic#78503) (elastic#78502) (elastic#78501) (elastic#78500) ...

) (#78533) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

michaelolo24 added Feature:Resolver Security Solution Resolver feature Team:Endpoint Data Visibility Team managing the endpoint resolver v7.10.0 v8.0.0 labels Sep 22, 2020

michaelolo24 force-pushed the update-timestamp-formatting branch from 54496d2 to 41a19cc Compare September 22, 2020 18:18

michaelolo24 marked this pull request as ready for review September 22, 2020 18:47

michaelolo24 requested review from a team as code owners September 22, 2020 18:47

oatkiller reviewed Sep 22, 2020

View reviewed changes

bkimmel reviewed Sep 22, 2020

View reviewed changes

michaelolo24 added the release_note:skip Skip the PR/issue when compiling release notes label Sep 22, 2020

michaelolo24 commented Sep 22, 2020

View reviewed changes

kqualters-elastic approved these changes Sep 22, 2020

View reviewed changes

bkimmel reviewed Sep 22, 2020

View reviewed changes

bkimmel approved these changes Sep 22, 2020

View reviewed changes

michaelolo24 force-pushed the update-timestamp-formatting branch 3 times, most recently from 4f7e4fc to 714a6cd Compare September 23, 2020 19:28

oatkiller approved these changes Sep 24, 2020

View reviewed changes

michaelolo24 added 7 commits September 24, 2020 14:20

update @timestamp formatting

c16cd12

handle missing timestamps

cf33fcd

remove unused translation

3d1a42a

add tests for date

c486114

types fix

155b82c

types fix

d22463c

types fix

a5f336a

michaelolo24 force-pushed the update-timestamp-formatting branch from 35bd5d9 to a5f336a Compare September 24, 2020 18:20

Merge branch 'master' into update-timestamp-formatting

ac56895

Merge branch 'master' into update-timestamp-formatting

24cf3c8

michaelolo24 merged commit 82ceb87 into elastic:master Sep 25, 2020

michaelolo24 deleted the update-timestamp-formatting branch September 25, 2020 12:33

michaelolo24 mentioned this pull request Sep 25, 2020

[7.x] [Security Solution][Resolver] Update @timestamp formatting (#78166) #78533

Merged

michaelolo24 added a commit to michaelolo24/kibana that referenced this pull request Sep 25, 2020

[Security Solution][Resolver] Update @timestamp formatting (elastic#7…

411e1e3

…8166) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

michaelolo24 added a commit that referenced this pull request Sep 29, 2020

[7.x] [Security Solution][Resolver] Update @timestamp formatting (#78166

9898a76

) (#78533) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Resolver] Update @timestamp formatting #78166

[Security Solution][Resolver] Update @timestamp formatting #78166

michaelolo24 commented Sep 22, 2020 •

edited

Loading

elasticmachine commented Sep 22, 2020

elasticmachine commented Sep 22, 2020

oatkiller Sep 22, 2020

michaelolo24 Sep 22, 2020

oatkiller Sep 22, 2020

michaelolo24 Sep 22, 2020

bkimmel Sep 22, 2020

oatkiller Sep 22, 2020

michaelolo24 Sep 22, 2020

bkimmel Sep 22, 2020

michaelolo24 Sep 22, 2020

bkimmel Sep 22, 2020

michaelolo24 Sep 22, 2020 •

edited

Loading

oatkiller commented Sep 22, 2020

michaelolo24 Sep 22, 2020

oatkiller Sep 22, 2020

michaelolo24 Sep 22, 2020

kqualters-elastic left a comment

bkimmel Sep 22, 2020

oatkiller left a comment

michaelolo24 commented Sep 24, 2020

michaelolo24 commented Sep 25, 2020

michaelolo24 commented Sep 25, 2020

kibanamachine commented Sep 25, 2020

[Security Solution][Resolver] Update @timestamp formatting #78166

[Security Solution][Resolver] Update @timestamp formatting #78166

Conversation

michaelolo24 commented Sep 22, 2020 • edited Loading

Summary

For maintainers

elasticmachine commented Sep 22, 2020

elasticmachine commented Sep 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michaelolo24 Sep 22, 2020 • edited Loading

Choose a reason for hiding this comment

oatkiller commented Sep 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kqualters-elastic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oatkiller left a comment

Choose a reason for hiding this comment

michaelolo24 commented Sep 24, 2020

michaelolo24 commented Sep 25, 2020

michaelolo24 commented Sep 25, 2020

kibanamachine commented Sep 25, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

History

michaelolo24 commented Sep 22, 2020 •

edited

Loading

michaelolo24 Sep 22, 2020 •

edited

Loading